This repository was archived by the owner on Jan 23, 2023. It is now read-only.
moving ARM HW Intrinsics files to shared partition#18451
Merged
Conversation
tannergooding
approved these changes
Jun 13, 2018
eerhardt
reviewed
Jun 13, 2018
| <Compile Include="$(MSBuildThisFileDirectory)System\Runtime\Intrinsics\X86\Ssse3.PlatformNotSupported.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(FeatureHardwareIntrinsics)' == 'true' AND '$(Platform)' == 'arm64'"> | ||
| <Compile Include="$(BclSourcesRoot)\System\Runtime\Intrinsics\Arm\Arm64\Aes.cs" /> |
Member
There was a problem hiding this comment.
These should all be $(MSBuildThisFileDirectory) instead of $(BclSourcesRoot), right? Like the ones above.
eerhardt
approved these changes
Jun 13, 2018
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Looks good. Thanks, @maryamariyan.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #18427 (comment) moving arm64 HWIntrinsics to shared partition.
Related to: #15922
cc: @eerhardt @tannergooding @sdmaclea, @CarolEidt