Move x86 HW intrinsics files to shared#18427
Conversation
Related to: #15922
| <Compile Include="$(BclSourcesRoot)\System\Runtime\Intrinsics\X86\Sse42.PlatformNotSupported.cs" /> | ||
| <Compile Include="$(BclSourcesRoot)\System\Runtime\Intrinsics\X86\Ssse3.PlatformNotSupported.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(Platform)' == 'arm64'"> |
There was a problem hiding this comment.
The arm64 HWIntrinsics should probably be moved as well. (CC. @sdmaclea, @CarolEidt, @eerhardt)
| <PlatformTarget>x64</PlatformTarget> | ||
| <Prefer32Bit>false</Prefer32Bit> | ||
| <BaseAddress>0x180000000</BaseAddress> | ||
| <DefineConstants>BIT64;AMD64;$(DefineConstants)</DefineConstants> |
There was a problem hiding this comment.
So where do these defines get defined for AMD64 now that you have deleted this block?
|
Build breaks... |
| <Prefer32Bit>false</Prefer32Bit> | ||
| <BaseAddress>0x180000000</BaseAddress> | ||
| <DefineConstants>BIT64;AMD64;$(DefineConstants)</DefineConstants> | ||
| <DefineConstants>BIT64;$(DefineConstants)</DefineConstants> |
There was a problem hiding this comment.
You cannot just stop defining AMD64 here. It is used when compiling CoreLib in multiple places.
We want to keep using AMD64 define for x64. It is pretty entrenched for historic reasons - changing it would be uphill battle.
There was a problem hiding this comment.
Only $(Platform) should be changed, to make it consistent with rest of world.
There was a problem hiding this comment.
Why makes changes here at all as part of this change? Why not a separate, targeted change?
|
@maryamariyan Thanks for the work! FYI, I changing some intrinsic APIs in #17637 that may impact your work. |
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Thanks, @maryamariyan!
Can you move the ARM files in the next PR?
|
@eerhardt will push up the next PR shortly after merging this |
* Switch platfom amd64 to x64 * Move x86 intrinsics file to shared * Adding condition so corert always picks up X.PlatformNotSupported.cs Related to: #15922 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Switch platfom amd64 to x64 * Move x86 intrinsics file to shared * Adding condition so corert always picks up X.PlatformNotSupported.cs Related to: #15922 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Switch platfom amd64 to x64 * Move x86 intrinsics file to shared * Adding condition so corert always picks up X.PlatformNotSupported.cs Related to: #15922 Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
* Switch platfom amd64 to x64 * Move x86 intrinsics file to shared * Adding condition so corert always picks up X.PlatformNotSupported.cs Related to: #15922 Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
* Switch platfom amd64 to x64 * Move x86 intrinsics file to shared * Adding condition so corert always picks up X.PlatformNotSupported.cs Related to: dotnet/coreclr#15922 Commit migrated from dotnet/coreclr@308850c
6 participants
Fixes: #15922