This repository was archived by the owner on Nov 1, 2020. It is now read-only.
[JustForView] Helps move x86 HW intrinsics files to shared in corert#5931
Closed
maryamariyan wants to merge 2 commits into
Closed
[JustForView] Helps move x86 HW intrinsics files to shared in corert#5931maryamariyan wants to merge 2 commits into
maryamariyan wants to merge 2 commits into
Conversation
jkotas
reviewed
Jun 12, 2018
| <Compile Include="$(MSBuildThisFileDirectory)System\Runtime\Intrinsics\X86\Sse42.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)System\Runtime\Intrinsics\X86\Ssse3.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(Platform)' != 'x64' AND '$(Platform)' != 'x86'"> |
Member
There was a problem hiding this comment.
CoreRT and ProjectN need to include the "PlatformNotSupported" files as well, for now at least.
Contributor
Author
There was a problem hiding this comment.
So do you mean for corert the condition on line 879 should always be true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NOTE] The diff in this PR is what will be cherry-picked into the mirroring PR from coreclr when dotnet/coreclr#18427 gets merged.
Diff details:
gitignore needs to be updated because the new files (to be moved from coreclr src to shared) are located in a folder named x86.
the second commit shows how the ifdefs could be simplified after the APIs are added.
cc: @jkotas @MichalStrehovsky