genPutArgStk needs to check for FIELD_LIST first

[CarolEidt]

When a struct is passed on the stack using FIELD_LIST, the type of the FIELD_LIST is the type of its first field. If that type was a struct type (i.e. a SIMD type), genPutArgStk would assume that it was the non-FIELD_LIST case.

Fix #18497

[CarolEidt]

@dotnet-bot test Linux-musl x64 Debug Build
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test
@dotnet-bot test Ubuntu x64 Formatting
@dotnet-bot test Windows_NT arm Cross Checked Innerloop Build and Test
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test
@dotnet-bot test Windows_NT x64 Checked Innerloop Build and Test
@dotnet-bot test Windows_NT x64 Formatting
@dotnet-bot test Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness
@dotnet-bot test Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness
@dotnet-bot test Windows_NT x86 Checked Innerloop Build and Test
@dotnet-bot test Windows_NT x86 Release Innerloop Build and Test
@dotnet-bot test Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness

[CarolEidt]

@dotnet-bot test Windows_NT x64 Checked jitstressregs3

[CarolEidt]

@dotnet-bot test Ubuntu x64 Checked jitstressregs3

[CarolEidt]

@dotnet/jit-contrib PTAL
Also, I'd like to run pri1 tests on this, but couldn't seem to find a match for that in the test strings. I think that the stress runs do the pri1 tests, and jitstressregs3 is generally the best at finding ABI issues. Is there a way to request the pri1 tests without stress?

[CarolEidt]

@dotnet-bot test Windows_NT x64 Checked jitstressregs3

[CarolEidt]

Note that codegenarmarch.cpp already does this in the appropriate order. See https://github.com/dotnet/coreclr/blob/master/src/jit/codegenarmarch.cpp#L650

[mikedn]

@CarolEidt Don't bother retrying jobs, the CI has been down pretty much all day. Some kind of network issue that prevents packages from being downloaded.

[CarolEidt]

@mikedn - thanks! I was seeing some of those errors on Friday and they succeeded on retry. But sounds like it's best to just wait.

[tannergooding]

@CarolEidt, looking at the netci.groovy and help output, all jobs not labeled as InnerLoop should be pri-1.

https://github.com/dotnet/coreclr/blob/master/netci.groovy#L2073
https://github.com/dotnet/coreclr/blob/master/netci.groovy#L3032

https://ci.dot.net/job/dotnet_coreclr/job/master/job/help_message/231/console

[jashook]

@dotnet-bot test Windows_NT arm64 Cross Checked normal Build and Test
@dotnet-bot test Windows_NT arm Cross Checked normal Build and Test
@dotnet-bot test Windows_NT x64 Build and Test
@dotnet-bot test Windows_NT x86 Checked Build and Test
@dotnet-bot test Ubuntu x64 Build and Test

[jashook]

lgtm fun bug.

[CarolEidt]

@dotnet-bot test Windows_NT x86 Checked Build and Test

[CarolEidt]

@dotnet/dnceng - any information on whatever is causing the dotnet cli install to fail?

[dagood]

The storage account was misconfigured, and it's fixed as of ~2 hours ago. (https://github.com/dotnet/core-eng/issues/3700) Rerunning the legs should now work.

[CarolEidt]

@dotnet-bot test Windows_NT arm64 Cross Checked normal Build and Test
@dotnet-bot test Windows_NT arm Cross Checked normal Build and Test
@dotnet-bot test Windows_NT x64 Build and Test
@dotnet-bot test Ubuntu x64 Build and Test
@dotnet-bot test Ubuntu x64 Checked Build and Test
@dotnet-bot test Ubuntu x64 Checked jitstressregs3

[CarolEidt]

@dotnet-bot test Windows_NT x64 Checked jitstressregs3

[CarolEidt]

@dotnet-bot test Ubuntu x64 Checked jitstressregs3

[CarolEidt]

Ignoring arm and arm64 since only codegenxarch.cpp has changed (plus the new test, which is not what's failing). These two tests are failing on both:
JIT\HardwareIntrinsics\X86\Avx\MaskLoad_r\MaskLoad_r.cmd
JIT\HardwareIntrinsics\X86\Avx\MaskLoad_ro\MaskLoad_ro.cmd

[sdmaclea]

@CarolEidt The new test fails with an assertion on arm64.

corerun GitHub_18497.exe

Assert failure(PID 38848 [0x000097c0], Thread: 38848 [0x97c0]): 
Assertion failed 'varDsc->lvFieldCnt == 1' in 'GitHub_18497:Sum(struct):struct' (IL size 18)

    File: src/jit/lclvars.cpp Line: 2020