This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix struct promotion check for SIMD field#18548
Merged
Merged
Conversation
A struct can have `lvIsRegArg` true but have multiple SIMD fields if it is passed by reference.
Author
|
@dotnet/jit-contrib PTAL |
Author
|
The arm and arm64 failures are the AVX/MaskLoad tests. I first saw these failing on #18499, which only changed codegenxarch.cpp, plus this test. |
|
The AVX/MaskLoad tests have been disabled in #17637 |
BruceForstall
approved these changes
Jun 19, 2018
Author
|
@fiigii - thanks for reminding me about those tests being deleted. |
Author
|
@sdmaclea - this fixes the assert that I see with the arm64 altjit on x64/windows. I'm going to merge this (which will close the issue). Could you verify that the test runs correctly and re-open the bug if it isn't fixed (or open another one if the symptom is different)? |
|
@CarolEidt Thanks. This resolved the issue on linux-arm64 as well. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
A struct can have `lvIsRegArg` true but have multiple SIMD fields if it is passed by reference. Commit migrated from dotnet/coreclr@d390551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A struct can have
lvIsRegArgtrue but have multiple SIMD fields if it is passed by reference.Fix #18544