This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Delete redundant broken offsetof definitions#18947
Merged
Merged
Conversation
Fixes build breaks with latest Visual Studio Preview. Fixes #18338
justinvp
reviewed
Jul 17, 2018
| #ifdef __GNUC__ | ||
| // GCC defines offsetof to be __builtin_offsetof, which doesn't use the | ||
| #if 1 | ||
| // Newer compiliers define offsetof to be __builtin_offsetof, which doesn't use the |
Member
Author
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Sep 25, 2018
Fixes build breaks with latest Visual Studio Preview. Fixes #18338
jkotas
added a commit
to jkotas/coreclr
that referenced
this pull request
Sep 25, 2018
Fixes build breaks with latest Visual Studio Preview. Fixes #18338
hoyosjs
added a commit
to hoyosjs/coreclr
that referenced
this pull request
Sep 26, 2018
Fixes build breaks with latest Visual Studio Preview.
hoyosjs
added a commit
to hoyosjs/coreclr
that referenced
this pull request
Sep 29, 2018
Fixes build breaks with latest Visual Studio Preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build breaks with latest Visual Studio Preview.
Fixes #18338