This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.2] Delete redundant broken offsetof definitions#20125
Closed
jkotas wants to merge 1 commit into
Closed
Conversation
Fixes build breaks with latest Visual Studio Preview. Fixes #18338
jkotas
added
area-Build
Servicing-consider
jkotas
changed the title
mikem8361
approved these changes
Sep 25, 2018
danmoseley
removed
the
Servicing-consider
Member
|
Porting to 2.2 is automatic. |
|
What do you mean automatic? Automatic shiproom approval? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The build fails on Windows x86 with updated C/C++ compiler.
Customer Impact
Building coreclr repo on Windows x86 fails with up-to-date Visual Studio 2017.
Regression?
No
Risk
No
Original issue: #18947