This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Handle COMMA nodes when morphing struct args#19234
Merged
Merged
Conversation
Author
|
@dotnet-bot test Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness |
Author
|
@dotnet/jit-contrib PTAL |
Author
|
This was introduced with my (relatively) recent changes (#18358) that eliminated some cases of unnecessary copies for Linux/x64. The code in |
BruceForstall
approved these changes
Aug 2, 2018
jashook
approved these changes
Aug 2, 2018
kouvel
added a commit
that referenced
this pull request
Aug 16, 2018
…" (#19505) This reverts commit 855ddf5. Issue https://github.com/dotnet/coreclr/issues/19124 was fixed by PR #19234, so re-enabling the test in minopts and with tiering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #19124