Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Revert "Temporarily flag a SIMD test as optimization-sensitive (#19163)"#19505

Merged
kouvel merged 1 commit into
dotnet:masterfrom
kouvel:EnableTest
Aug 16, 2018
Merged

Revert "Temporarily flag a SIMD test as optimization-sensitive (#19163)"#19505
kouvel merged 1 commit into
dotnet:masterfrom
kouvel:EnableTest

Conversation

@kouvel
Copy link
Copy Markdown

@kouvel kouvel commented Aug 15, 2018

This reverts commit 855ddf5 (PR #19163). Issue https://github.com/dotnet/coreclr/issues/19124 was fixed by PR #19234, so re-enabling the test in minopts and with tiering.

This reverts commit 855ddf5. Issue https://github.com/dotnet/coreclr/issues/19124 was fixed by PR #19234, so re-enabling the test in minopts and with tiering.
@kouvel kouvel added this to the 3.0 milestone Aug 15, 2018
@kouvel kouvel self-assigned this Aug 15, 2018
@kouvel kouvel requested a review from BruceForstall August 15, 2018 19:29
Copy link
Copy Markdown

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell if there are any specific test jobs that should be triggered to verify this, but if there are some, please do trigger those.

@kouvel
Copy link
Copy Markdown
Author

kouvel commented Aug 15, 2018

@dotnet-bot test Ubuntu x64 Checked minopts
test OSX10.12 x64 Checked minopts

@kouvel
Copy link
Copy Markdown
Author

kouvel commented Aug 16, 2018

All of the perf runs have this similar failure, which is unrelated to this change:

13:54:51 [tests\scripts\run-xunit-perf.py]: py D:\j\w\perf_perflab_---89ec9f56\Microsoft.Benchview.JSONFormat\tools\measurement.py xunit --better desc --drop-first-value --append D:\j\w\perf_perflab_---89ec9f56\bin\sandbox_logs\Microbenchmarks\Off\PerfLab\Perf-Off-PerfLab.xml
13:54:51 Traceback (most recent call last):
13:54:51   File "tests\scripts\run-xunit-perf.py", line 530, in <module>
13:54:51     sys.exit(main(Args))
13:54:51   File "tests\scripts\run-xunit-perf.py", line 521, in main
13:54:51     upload_to_benchview(python, coreclrRepo, benchviewPath, uploadToBenchview, benchviewGroup, runType, configuration, operatingSystem, etwCollection, optLevel, jitName, pgoOptimized, arch)
13:54:51   File "tests\scripts\run-xunit-perf.py", line 285, in upload_to_benchview
13:54:51     raise Exception('%s does not exist. There is no data to be uploaded.' % jsonFile)
13:54:51 Exception: D:\j\w\perf_perflab_---89ec9f56\submission-metadata.json does not exist. There is no data to be uploaded.

@kouvel kouvel merged commit 0c64ced into dotnet:master Aug 16, 2018
@kouvel kouvel deleted the EnableTest branch August 16, 2018 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants