Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix ilasm exec on paths with spaces#21819

Merged
jkotas merged 1 commit intodotnet:masterfrom
ViktorHofer:EmptySpacesIL
Jan 5, 2019
Merged

Fix ilasm exec on paths with spaces#21819
jkotas merged 1 commit intodotnet:masterfrom
ViktorHofer:EmptySpacesIL

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer commented Jan 4, 2019 •
edited
Loading

Quotes were missing which results in errors when executing ilasm on paths with spaces. I assume that a new package will be available via BAR after this is merged?

@ViktorHofer ViktorHofer self-assigned this Jan 4, 2019
@jkotas jkotas merged commit b188e9d into dotnet:master Jan 5, 2019
@ViktorHofer ViktorHofer deleted the EmptySpacesIL branch January 5, 2019 10:27
@benaadams
Copy link
Copy Markdown
Member

benaadams commented Jan 6, 2019

Might be causing issue for corefx merge?

dotnet/corefx#34375 (comment)

tmp/tmpb5d520e53b7a47cfb612f48d141d38af.exec.cmd: line 2: 
 /mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_x64+TestOuter_false_prtest/
 Tools/ilasm\ilasm: No such file or directory
07:35:52 /mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_x64+TestOuter_false_prtest/
.packages/microsoft.net.sdk.il/3.0.0-preview-27306-02/targets
 /Microsoft.NET.Sdk.IL.targets(88,5):
 error MSB3073: The command
 ""/mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_x64+TestOuter_false_prtest/Tools/ilasm\ilasm" -QUIET -NOLOGO -OPTIMIZE -DLL  -INCLUDE=include\netcoreapp -OUTPUT="/mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_x64+TestOuter_false_prtest/artifacts/obj/System.Runtime.CompilerServices.Unsafe/netcoreapp-Release/System.Runtime.CompilerServices.Unsafe.dll" -KEY="/mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_x64+TestOuter_false_prtest/.packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.19054.13/tools/snk/MSFT.snk" System.Runtime.CompilerServices.Unsafe.il"
 exited with code 127. [/mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj]

@benaadams benaadams mentioned this pull request Jan 6, 2019
Merged
@benaadams
Copy link
Copy Markdown
Member

benaadams commented Jan 6, 2019

Looks like it causes problems on linux/macOS; perhaps due to backslash in path (now in quotes)?

.../Tools/ilasm\ilasm

jkotas added a commit that referenced this pull request Jan 6, 2019
@jkotas
Revert "Fix ilasm exec on paths with spaces (#21819)"
57abbba 
This reverts commit b188e9d.
jkotas added a commit to jkotas/coreclr that referenced this pull request Jan 6, 2019
@jkotas
Revert "Fix ilasm exec on paths with spaces (dotnet#21819)"
c334298 
This reverts commit b188e9d.
@jkotas
Copy link
Copy Markdown
Member

jkotas commented Jan 6, 2019

Reverting in #21835 to unblock codeflow.

jkotas added a commit that referenced this pull request Jan 6, 2019
@jkotas
Revert "Fix ilasm exec on paths with spaces (#21819)" (#21835)
c3a4a5b 
This reverts commit b188e9d.
@ViktorHofer
Copy link
Copy Markdown
Member Author

ViktorHofer commented Jan 6, 2019

Sorry for the inconvenience! I just submitted a fix for this: #21837

sandreenko pushed a commit to sandreenko/coreclr that referenced this pull request Jan 8, 2019
@ViktorHofer
Fix ilasm exec on paths with spaces (dotnet#21819)
3453d8c
sandreenko pushed a commit to sandreenko/coreclr that referenced this pull request Jan 8, 2019
@jkotas
Revert "Fix ilasm exec on paths with spaces (dotnet#21819)" (dotnet#2…
d40fd59 
…1835)

This reverts commit b188e9d.
@PRIMETSS PRIMETSS mentioned this pull request Feb 1, 2020
Closed
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@ViktorHofer @jkotas
Fix ilasm exec on paths with spaces (dotnet/coreclr#21819)
a8eaff0 
Commit migrated from dotnet/coreclr@b188e9d
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@jkotas
Revert "Fix ilasm exec on paths with spaces (dotnet/coreclr#21819)" (d…
18744ba 
…otnet/coreclr#21835)

This reverts commit dotnet/coreclr@b188e9d.

Commit migrated from dotnet/coreclr@c3a4a5b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding Awaiting requested review from tannergooding

@RussKeldorph RussKeldorph Awaiting requested review from RussKeldorph

2 more reviewers

@danmoseley danmoseley danmoseley approved these changes

@jkotas jkotas jkotas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ViktorHofer ViktorHofer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer @benaadams @jkotas @danmoseley