This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Attempt to fix paths with spaces again#21837
Merged
ViktorHofer merged 1 commit intodotnet:masterfrom Jan 8, 2019
Merged
Conversation
Member
|
Think the Ubuntu arm legs are busted currently (never completing) |
Member
|
LGTM - assuming that you have verified CoreFX builds fine with these changes. |
jkotas
approved these changes
Jan 7, 2019
Member
Author
|
I tested on Windows as before but given that the error only occurred on Unix I also tried testing on WSL but hit some errors. Given my certainty that the fix is correct I will merge this. |
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Jan 8, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/coreclr@b3498fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems setting quotes hinders msbuild to transform supplied slashes to the format expected by the file system. Using msbuild path functions always sets the right paths and NormalizeDirectory also appends the right slash.