This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix RVA field placement order#24047
Merged
Merged
Conversation
jkotas
reviewed
Apr 17, 2019
jkotas
reviewed
Apr 17, 2019
jkotas
approved these changes
Apr 17, 2019
Member
|
Can we add a test for this so that there's something to test this with for CPAOT? (Plus, regression tests never hurt.) |
added 3 commits
April 18, 2019 12:09
…tion to not break Managed C++ binaries in R2R
fadimounir
force-pushed
the
Fix23872_rva
branch
from
508f3f4 to
35ef4e5
Compare
Author
|
@MichalStrehovsky Test added |
jkotas
reviewed
Apr 18, 2019
|
@fadimounir - this test is also failing in |
Author
|
@CarolEidt I just merged a fix #24119 |
|
Thanks @fadimounir ! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Static RVA fields should be placed sequentially after the qsort operation to not break Managed C++ binaries in R2R * Add regression test Commit migrated from dotnet/coreclr@1a2bc6c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #23872
RVA fields should be placed in the R2R image after a correct qsort operation, and not as part of ZapNode relocs placement during compilation. This fixes the Managed C++ binaries scenario in R2R.
Updating the qsort callback to sort by descending size for fields of equal RVA: we do this for fragile NIs