This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Adding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128)#24102
Merged
Conversation
Member
Author
|
This is marked * NO MERGE * as it is pending @terrajobst marking it as API Approved before EOD today. |
Member
Author
Member
Author
|
API has been marked approved now. Thanks! |
Member
Author
|
@fadimounir, failures look related to #24047 |
|
@tannergooding How are the failures related to #24047? |
Member
Author
|
@fadimounir, failures are: The projects listed look to have been just added in #24047 |
Member
Author
|
It looks like it can't resolve the debug type or optimization type of the project. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…(long*, V128) (dotnet/coreclr#24102) Commit migrated from dotnet/coreclr@4686029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the CoreCLR side of https://github.com/dotnet/corefx/issues/36746.
Once this is merged and flows into CoreFX, the reference assembly can be updated. Then, that will flow back into CoreCLR at which point we can remove the old API and fixup the tests. Doing it this way (as we have in the past) minimizes the risk of CoreFX/CoreCLR getting out of sync and being in a "torn" state.