Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Adding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128)#24102

Merged
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:fix-36746
Apr 19, 2019
Merged

Adding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128)#24102
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:fix-36746

Conversation

@tannergooding
Copy link
Copy Markdown
Member

This is the CoreCLR side of https://github.com/dotnet/corefx/issues/36746.

Once this is merged and flows into CoreFX, the reference assembly can be updated. Then, that will flow back into CoreCLR at which point we can remove the old API and fixup the tests. Doing it this way (as we have in the past) minimizes the risk of CoreFX/CoreCLR getting out of sync and being in a "torn" state.

@tannergooding tannergooding added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 18, 2019
@tannergooding
Copy link
Copy Markdown
Member Author

This is marked * NO MERGE * as it is pending @terrajobst marking it as API Approved before EOD today.

@tannergooding tannergooding requested a review from CarolEidt April 18, 2019 21:23
@tannergooding
Copy link
Copy Markdown
Member Author

CC. @terrajobst, @GrabYourPitchforks

Copy link
Copy Markdown

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tannergooding tannergooding removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 18, 2019
@tannergooding
Copy link
Copy Markdown
Member Author

API has been marked approved now. Thanks!

@tannergooding
Copy link
Copy Markdown
Member Author

@fadimounir, failures look related to #24047

@tannergooding tannergooding merged commit 4686029 into dotnet:master Apr 19, 2019
@fadimounir
Copy link
Copy Markdown

@tannergooding How are the failures related to #24047?

@tannergooding
Copy link
Copy Markdown
Member Author

@fadimounir, failures are:

      JIT\CheckProjects\CheckProjects\CheckProjects.cmd [FAIL]
16:09:35         
16:09:35         Return code:      1
16:09:35         Raw output file:      C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\Reports\JIT.CheckProjects\CheckProjects\CheckProjects.output.txt
16:09:35         Raw output:
16:09:35         BEGIN EXECUTION
16:09:35         
16:09:35         C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\JIT\CheckProjects\CheckProjects>set COMPLUS_NOGUIONASSERT=1 
16:09:35         
16:09:35         C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\JIT\CheckProjects\CheckProjects>set COMPLUS_CONTINUEONASSERT=0 
16:09:35          "C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\Tests\Core_Root\corerun.exe" CheckProjects.exe 
16:09:35         Scanning projects under C:\j\workspace\arm_cross_che---c874ca48\tests\src\JIT
16:09:35         C:\j\workspace\arm_cross_che---c874ca48\tests\src\JIT\Directed\rvastatics\RVAOrderingTest.ilproj DebugType-n/a-SuffixNone
16:09:35         C:\j\workspace\arm_cross_che---c874ca48\tests\src\JIT\Directed\rvastatics\RVAOrderingTest.ilproj Optimize-n/a
16:09:35         7030 projects, 1 needed fixes, 0 were fixed
16:09:35         Expected: 100
16:09:35         Actual: -1
16:09:35         END EXECUTION - FAILED
16:09:35         FAILED
16:09:35         Test Harness Exitcode is : 1
16:09:35         To run the test:
16:09:35         > set CORE_ROOT=C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\Tests\Core_Root
16:09:35         > C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\JIT\CheckProjects\CheckProjects\CheckProjects.cmd
16:09:35         Expected: True
16:09:35         Actual:   False
16:09:35         Stack Trace:
16:09:35           D:\j\workspace\arm_cross_che---7ce81708\bin\tests\Windows_NT.arm.Checked\TestWrappers\JIT.CheckProjects\JIT.CheckProjects.XUnitWrapper.cs(129,0): at JIT_CheckProjects._CheckProjects_CheckProjects_._CheckProjects_CheckProjects_cmd()
16:09:35         Output:
16:09:35           
16:09:35           Return code:      1
16:09:35           Raw output file:      C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\Reports\JIT.CheckProjects\CheckProjects\CheckProjects.output.txt
16:09:35           Raw output:
16:09:35           BEGIN EXECUTION
16:09:35           
16:09:35           C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\JIT\CheckProjects\CheckProjects>set COMPLUS_NOGUIONASSERT=1 
16:09:35           
16:09:35           C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\JIT\CheckProjects\CheckProjects>set COMPLUS_CONTINUEONASSERT=0 
16:09:35            "C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\Tests\Core_Root\corerun.exe" CheckProjects.exe 
16:09:35           Scanning projects under C:\j\workspace\arm_cross_che---c874ca48\tests\src\JIT
16:09:35           C:\j\workspace\arm_cross_che---c874ca48\tests\src\JIT\Directed\rvastatics\RVAOrderingTest.ilproj DebugType-n/a-SuffixNone
16:09:35           C:\j\workspace\arm_cross_che---c874ca48\tests\src\JIT\Directed\rvastatics\RVAOrderingTest.ilproj Optimize-n/a
16:09:35           7030 projects, 1 needed fixes, 0 were fixed
16:09:35           Expected: 100
16:09:35           Actual: -1
16:09:35           END EXECUTION - FAILED
16:09:35           FAILED
16:09:35           Test Harness Exitcode is : 1
16:09:35           To run the test:
16:09:36           > set CORE_ROOT=C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\Tests\Core_Root
16:09:36           > C:\j\workspace\arm_cross_che---c874ca48\bin\tests\Windows_NT.arm.Checked\JIT\CheckProjects\CheckProjects\CheckProjects.cmd

The projects listed look to have been just added in #24047

@tannergooding
Copy link
Copy Markdown
Member Author

It looks like it can't resolve the debug type or optimization type of the project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants