This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Ensure that we check for implicit ivals for single argument intrinsics before the SIMDScalar handling.#25905
Merged
Conversation
…s before the SIMDScalar handling.
Member
Author
|
CC. @CarolEidt, @jkotas, @danmosemsft As per #25901 (comment) |
Member
Author
|
CC. @AndyAyersMS, would you be able to give this a review pass since the normal reviewers are both OOF right now. Once it is merged into master, I will also need to open a PR backporting it to release/3.0 |
AndyAyersMS
approved these changes
Jul 30, 2019
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Are you going to add test cases?
Member
Author
Yes, I'll get those added to the PR. |
Member
Author
|
Added tests covering the missed scenarios. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…s before the SIMDScalar handling. (dotnet/coreclr#25905) * Ensure that we check for implicit ivals for single argument intrinsics before the SIMDScalar handling. * Adding test template entries for the unary overloads of the Sse41.Round functions * Regenerating the hardware intrinsic test templates. Commit migrated from dotnet/coreclr@bcc73ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves https://github.com/dotnet/coreclr/issues/25904.
This should likely be backported to release/3.0.