This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Ensure that we check for implicit ivals for single argument intrinsics before the SIMDScalar handling.#25987
Merged
Conversation
…s before the SIMDScalar handling. (#25905) * Ensure that we check for implicit ivals for single argument intrinsics before the SIMDScalar handling. * Adding test template entries for the unary overloads of the Sse41.Round functions * Regenerating the hardware intrinsic test templates.
Member
Author
|
CC. @CarolEidt, @AndyAyersMS This is the backport of #25905 to release/3.0. This needs @MeiChin-Tsai's approval as well, correct? |
AndyAyersMS
approved these changes
Aug 2, 2019
Member
At a minimum -- there may be more process now. |
Member
It needs to get ok from Tactics on Tues. |
Member
Member
|
(assuming CI is green) |
Member
|
Branch is open, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Certain intrinsic functions which took one argument, had an implicit immediate value , and were marked as
SIMDScalarwere not being handled correctly in codegen.Customer Impact
Customers using functions qualifying under the above conditions would get invalid results in their program.
Regression?
Yes, as per the description.
Risk
Low. This just reorders the branch statements and the list of intrinsics that are impacted is small and well-defined: there are 102 intrinsics marked
SIMDScalarand only 7 of them have both an implicit immediate value and take one argument.