First step to create nuget packages for ARM32/Linux by hseok-oh · Pull Request #8421 · dotnet/coreclr

hseok-oh · 2016-12-02T02:41:05Z

Modify src/.nuget to create nuget package files for ARM32/Linux (cross build).
It excludes *.ni.dll generated by crossgen.

generate for

ARM32 hardfp Linux: ubuntu 14.04 - default root file system for cross build
ARM32 hardfp Linux: ubuntu 16.04 - Raspberry Pi 3

jkotas · 2016-12-02T02:47:46Z

cc @gkhanna79

gkhanna79 · 2016-12-02T05:55:17Z

    <ProjectReference Include="alpine\3.4.3\Microsoft.NETCore.ILAsm.pkgproj">
      <Platform>amd64</Platform>
    </ProjectReference>
+    <ProjectReference Include="ubuntu\14.04\Microsoft.NETCore.ILAsm.pkgproj">


Please keep these next to the other 16.04 (or 14.04) entries for consistency.

Same for other such changes in this PR.

gkhanna79 · 2016-12-02T05:58:12Z

  <ItemGroup>
    <NativeSplittableBinary Include="$(BinDir)libcoreclr.so" />
-    <NativeSplittableBinary Include="$(BinDir)libcoreclrtraceptprovider.so" />
+    <NativeSplittableBinary Condition="'$(PackagePlatform)' != 'arm'" Include="$(BinDir)libcoreclrtraceptprovider.so" />


Why do we need this conditional (are we not building it for Arm)?

Yes. This file is not build for ARM.

Why is the traceprovider not built for Arm?

Still waiting on this.

I found why is it not built for ARM.
FEATURE_EVENT_TRACE is not set for ARM build. (src/pal/CMakeLists.txt)

I am building on the Raspberry PI 3 Raspian.
So, when the build is properly enabled (there was one more place where the feature was set for PAL, I was setting it in clrdefinitions.cmake only before), it fails in /usr/include/urcu/uatomic/generic.h, which is a header that belongs to the lttng. I can see it is a known issue that was reported and fixed in lttng more than a year ago (http://comments.gmane.org/gmane.linux.kernel.tracing.lttng.devel/10012). So maybe there are too old lttng libraries on my Raspbian or something. But I have just installed the liblttng-ust-dev package avaiable in Raspbian. And the version and header seems to be the same as the one on my AMD64 ubuntu, so I wonder if the problem is in clang 3.7 being more sensitive.

I just made the two changes and completed a build successfully on Linux Mint - my changes are in https://github.com/gkhanna79/coreclr/tree/ArmLTTNG. If these look good, then @hseok-oh can you please incorporate them as libcoreclrtraceptprovider.so is getting built?

Successfully build libcoreclrtraceptprovider.so by @gkhanna79's patch with my private rootfs (based on ubuntu-mate 16.04). But it fails with default rootfs (ubuntu 14.04) for ARM cross build, and fails in /usr/include/urcu/uatomic/generic.h like @janvorli.

#3879 (comment)
#3879 (comment)

IMHO, it's better excluding libcoreclrtraceptprovider.so for ARM and fix it later.

@hseok-oh Please file an issue for building this for Arm to ensure we dont miss it.

With that said, I think the rest of the PR LGTM to merge.

gkhanna79 · 2016-12-02T06:00:38Z

    <ArchitectureSpecificNativeFile Include="$(BinDir)sosdocsunix.txt" />
-    <ArchitectureSpecificNativeFile Include="$(BinDir)mscorlib.ni.dll" />
-    <ArchitectureSpecificNativeFile Include="$(BinDir)System.Private.CoreLib.ni.dll" />
+    <ArchitectureSpecificNativeFile Condition="'$(PackagePlatform)'!='arm'" Include="$(BinDir)mscorlib.ni.dll" />


I presume you are doing this because cross-compilation done on a non-Arm machine (e.g. x64) does not build a x86 (or x64) hosted crossgen that can generate Arm code,right? If it, i think it will really help to bring up the x86 Linux build as that will help build a x86-hosted crossgen that generate arm32 BI images and thus, alleviating the need for these.

Exactly. We also think implementing x86-host/arm-target crossgen as future work.

Thank you @hseok-oh. Can you please file an issue for "Building cross-targeting components" for Linux Arm32 bringup?

gkhanna79 · 2016-12-02T06:03:41Z

    fi
 }

+initTargetDistroRid()


Instead of this function, why can we not fix https://github.com/dotnet/coreclr/pull/8421/files#diff-0b83f9dedf40d7356e5ca147a077acb4R67 to use $__BuildArch instead of $__HostArch?

$__DistroRid is used in https://github.com/hseok-oh/coreclr/blob/5145193d4970eaf9a008014a7b02307611bd96ef/build.sh#L237 before nuget packaging, and this function need host environment information to use msbuild on .net core.

Given the above, I would suggest that you rename the current $__DistroRid to $__HostDistroRid and your proposed $__CrossDistroRid as $__DistroRid. This will maintain the existing uses and convey the correct meaning via $__DistroRid and also eliminate your changes in dir.props.

gkhanna79 · 2016-12-02T06:04:38Z

    <TargetsWindows Condition="'$(BuildOS)' == 'Windows_NT'">true</TargetsWindows>

    <TargetsUnix Condition="'$(TargetsFreeBSD)' == 'true' or '$(TargetsLinux)' == 'true' or '$(TargetsNetBSD)' == 'true' or '$(TargetsOSX)' == 'true'">true</TargetsUnix>
+    <TargetsLinuxCross Condition="'$(TargetsLinux)' == 'true' and '$(CROSSCOMPILE)' != ''">true</TargetsLinuxCross>


I dont think we need cross-compilation identification like this. We perform cross-compilation on Windows as well without requiring this.

See my comment above - if we can use a single function that defines the DistroRid correctly, then your change here is not required.

If the environment variable '$__DistroRid' is not used in other place, we can overwrite the value of $__DistroRidCross to $__DistroRid in build.sh. Then we don't need TargetLinuxCross.

See my comment above on how to address it.

gkhanna79 · 2016-12-02T06:10:00Z

Also, please add the RID definition athttps://github.com/dotnet/corefx/blob/master/pkg/Microsoft.NETCore.Platforms/runtime.json before using it here for package generation.

dnfclas · 2016-12-02T08:45:16Z

@hseok-oh, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

…dir.prop

dnfclas · 2016-12-06T01:20:33Z

@hseok-oh, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

hseok-oh · 2016-12-06T01:27:34Z

@gkhanna79 PTAL

gkhanna79 · 2016-12-06T18:23:24Z

  <ItemGroup>
    <NativeSplittableBinary Include="$(BinDir)libcoreclr.so" />
-    <NativeSplittableBinary Include="$(BinDir)libcoreclrtraceptprovider.so" />
+    <NativeSplittableBinary Condition="'($PackagePlatform)' == 'arm'" Include="$(BinDir)libcoreclrtraceptprovider.so" />


This should be "!=" and not "==".

And likewise for other such comparisons.

gkhanna79 · 2016-12-06T18:24:11Z

    <ArchitectureSpecificNativeFile Include="$(BinDir)sosdocsunix.txt" />
-    <ArchitectureSpecificNativeFile Include="$(BinDir)mscorlib.ni.dll" />
-    <ArchitectureSpecificNativeFile Include="$(BinDir)System.Private.CoreLib.ni.dll" />
+    <ArchitectureSpecificNativeFile Condition="'($PackagePlatform)' == 'arm'" Include="$(BinDir)mscorlib.ni.dll" />


Same as above.

gkhanna79 · 2016-12-06T18:24:20Z

-    <ArchitectureSpecificNativeFile Include="$(BinDir)mscorlib.ni.dll" />
-    <ArchitectureSpecificNativeFile Include="$(BinDir)System.Private.CoreLib.ni.dll" />
+    <ArchitectureSpecificNativeFile Condition="'($PackagePlatform)' == 'arm'" Include="$(BinDir)mscorlib.ni.dll" />
+    <ArchitectureSpecificNativeFile Condition="'($PackagePlatform)' == 'arm'" Include="$(BinDir)System.Private.CoreLib.ni.dll" />


Same as above.

gkhanna79 · 2016-12-09T16:09:58Z

@hseok-oh Are we good to merge this change?

hseok-oh · 2016-12-12T00:54:31Z

@gkhanna79 merge this PR, please. Thanks.

…_nupkg First step to create nuget packages for ARM32/Linux Commit migrated from dotnet/coreclr@e7d1919

First step to generate nuget package for ARM32/Linux

5145193

dnfclas added the cla-required label Dec 2, 2016

gkhanna79 reviewed Dec 2, 2016

View reviewed changes

hseok-oh mentioned this pull request Dec 2, 2016

Add RID for Linux/ARM32 (ubuntu) dotnet/corefx#14161

Merged

dnfclas added cla-signed and removed cla-required labels Dec 2, 2016

Change order in .builds and .pkgproj, fix build.sh for not modifying …

d068783

…dir.prop

dnfclas added the cla-signed label Dec 6, 2016

fix semicolon

ee20b69

gkhanna79 reviewed Dec 6, 2016

View reviewed changes

Hyeongseok Oh added 2 commits December 7, 2016 09:50

fix comparison

779bee2

fix parentheses

da8cc3a

gkhanna79 merged commit e7d1919 into dotnet:master Dec 12, 2016

hseok-oh deleted the enable_arm_linux_nupkg branch December 15, 2016 08:45

jkotas mentioned this pull request Feb 13, 2017

[Arm Unix build] arm variants of System.Native.a and libSystem.Globalization.Native.a are needed for cross building tests dotnet/corert#2739

Open

karelz modified the milestone: 2.0.0 Aug 28, 2017

cydhaselton mentioned this pull request Jan 22, 2020

Enabling Android ARM64 for .NET Core dotnet/runtime#2044

Closed

8 tasks

hqueue mentioned this pull request Jan 30, 2020

Enabling Linux ARM32 for .NET Core dotnet/runtime#2548

Closed

42 tasks

This was referenced Jan 31, 2020

[ARM32/Linux] CoreCLR building issues for ARM32 on Linux dotnet/runtime#7115

Closed

[ARM32/Linux] libcoreclrtraceptprovider.so build dotnet/runtime#7152

Closed

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022

Merge pull request dotnet/coreclr#8421 from hseok-oh/enable_arm_linux…

2824bc0

…_nupkg First step to create nuget packages for ARM32/Linux Commit migrated from dotnet/coreclr@e7d1919

Conversation

hseok-oh commented Dec 2, 2016

Uh oh!

jkotas commented Dec 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hseok-oh Dec 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkhanna79 commented Dec 2, 2016

Uh oh!

dnfclas commented Dec 2, 2016

Uh oh!

dnfclas commented Dec 6, 2016

Uh oh!

hseok-oh commented Dec 6, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkhanna79 commented Dec 9, 2016

Uh oh!

hseok-oh commented Dec 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hseok-oh Dec 8, 2016 •

edited

Loading