Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add RID for Linux/ARM32 (ubuntu)#14161

Merged
mellinoe merged 1 commit into
dotnet:masterfrom
hseok-oh:add_rid_armlinux
Dec 5, 2016
Merged

Add RID for Linux/ARM32 (ubuntu)#14161
mellinoe merged 1 commit into
dotnet:masterfrom
hseok-oh:add_rid_armlinux

Conversation

@hseok-oh
Copy link
Copy Markdown

@hseok-oh hseok-oh commented Dec 2, 2016

Add RID for Linux/ARM32 - ubuntu*-arm

related PR: dotnet/coreclr#8421

@dnfclas
Copy link
Copy Markdown

dnfclas commented Dec 2, 2016

Hi @hseok-oh, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link
Copy Markdown

dnfclas commented Dec 2, 2016

@hseok-oh, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@stephentoub
Copy link
Copy Markdown
Member

cc: @ericstj, @mellinoe, @ellismg

@mellinoe
Copy link
Copy Markdown
Contributor

mellinoe commented Dec 3, 2016

Looks good to me. Could you also add extra entries for Linux Mint? We consider it binary-compatible with Ubuntu.

@hseok-oh
Copy link
Copy Markdown
Author

hseok-oh commented Dec 5, 2016

@mellinoe I don't have environment that installed Linux Mint, so I don't know proper RID for Linux Mint.

@ellismg
Copy link
Copy Markdown
Contributor

ellismg commented Dec 5, 2016

I don't believe there is actually an ARM version of Mint (even with it being downstream of Ubuntu). There's now download link on linuxmint.com and the forums imply that there is no ARM version.

@mellinoe
Copy link
Copy Markdown
Contributor

mellinoe commented Dec 5, 2016

Good point, @ellismg . That was a bad assumption on my part. The rest of this looks good to me.

@mellinoe mellinoe merged commit 5b10083 into dotnet:master Dec 5, 2016
@karelz karelz modified the milestone: 1.2.0 Dec 6, 2016
@hseok-oh hseok-oh deleted the add_rid_armlinux branch February 27, 2017 01:39
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants