This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Sorted set builder indexer#11
Merged
dotnet-bot merged 1 commit intodotnet:masterfrom Nov 11, 2014
AArnott:SortedSetBuilderIndexer
Merged
Sorted set builder indexer#11dotnet-bot merged 1 commit intodotnet:masterfrom AArnott:SortedSetBuilderIndexer
dotnet-bot merged 1 commit intodotnet:masterfrom
AArnott:SortedSetBuilderIndexer
Conversation
Contributor
|
Would you mind squashing these? I don't think there's value in having the erroneous comment and its immediate revert back-to-back in the master history. Otherwise, looks good. |
Author
|
Done. But I imagine as we get in the habit of accepting pull requests, there will be all sorts of colored history in those commits that then get cleaned up by subsequent commits prior to making the pull request. And in general, I think asking them to squash their history would be a destructive operation and very disruptive to other forks of the project(s) involved. |
The indexer is available on the immutable type, so its absence from the Builder is notable. Fortunately, it's simple to correct. New tests included.
Contributor
|
Fair. I will keep this in mind. |
Olafski
pushed a commit
to Olafski/corefx
that referenced
this pull request
Jun 15, 2017
Olafski
pushed a commit
to Olafski/corefx
that referenced
this pull request
Jun 15, 2017
This commit fixes dotnet#11 - Add getting started links to readme.md
ravimeda
added a commit
that referenced
this pull request
Jun 16, 2017
* Create root and windows definition. * Include PB_ prefix. * Remove variables whose values will be in PB. * Remove unnecessary tasks. * Update path property. * Add OSX leg. * Remove triggers. * Remove PB variables. * Remove OSX leg since there is no TSA support. * Remove CodeMetrics. * Pass official build number as PB variable. * Invoke sync.cmd directly. * Update arguments passed to security tools. (#11) * Minor fixes to arguments passed, and variable names. (#12) * Remove folders other than security. * Update args for BinSkim. * Cleanup scripts. * Fix APIScan args. * Update task names. * Update PB variable name. * Do delete .txt files. Version.txt is needed. * Set symbolsFolder for APIScan. * Update git checkout task. * Add a test task that will be removed before merge. * Add PB_Git variable. * Update Git path. * Revert to PB_Git. * Remove test task.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Create root and windows definition. * Include PB_ prefix. * Remove variables whose values will be in PB. * Remove unnecessary tasks. * Update path property. * Add OSX leg. * Remove triggers. * Remove PB variables. * Remove OSX leg since there is no TSA support. * Remove CodeMetrics. * Pass official build number as PB variable. * Invoke sync.cmd directly. * Update arguments passed to security tools. (dotnet/corefx#11) * Minor fixes to arguments passed, and variable names. (dotnet/corefx#12) * Remove folders other than security. * Update args for BinSkim. * Cleanup scripts. * Fix APIScan args. * Update task names. * Update PB variable name. * Do delete .txt files. Version.txt is needed. * Set symbolsFolder for APIScan. * Update git checkout task. * Add a test task that will be removed before merge. * Add PB_Git variable. * Update Git path. * Revert to PB_Git. * Remove test task. Commit migrated from dotnet/corefx@114dc02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add indexer to SortedSet`1+Builder class.