Add ExcludeFromCodeCoverageAttribute#11986
Conversation
|
@Wesh look ok? |
| [Fact] | ||
| public void ExcludeFromCodeCoverageAttribute_Instantiate() | ||
| { | ||
| new ExcludeFromCodeCoverageAttribute();throw null; |
There was a problem hiding this comment.
How is it that all of the tests passed when there's this explicit throw null here?
There was a problem hiding this comment.
Uh - my bad, I was verifying that the tests were running. Clearly, they're not.
There was a problem hiding this comment.
It's not building the test .csproj with '$(TargetGroup)'=='netstandard1.7'. Hmm.
danmoseley
force-pushed
the
dan.excludecodecover2
branch
2 times, most recently
from
1b4c948 to
3903340
Compare
|
Actually, this may need to be a case of exposing from coreclr instead. |
|
@ericstj Can you confirm it's correct to put this into corefx ? I thought so as it's not exposed publicly from the base library, but I seem to remember you may have said otherwise. |
|
@danmosemsft, what are the next steps on this one? Are you still waiting for feedback from @ericstj? Thanks. |
|
LGTM after rebase. |
danmoseley
force-pushed
the
dan.excludecodecover2
branch
3 times, most recently
from
3c0fc7d to
3fdb2e6
Compare
danmoseley
force-pushed
the
dan.excludecodecover2
branch
from
3fdb2e6 to
78575e6
Compare
|
Hit a CI timeout https://github.com/dotnet/corefx/issues/12252 but need to rebase anyway. |
| "netstandard1.7": {} | ||
| }, | ||
| "supports": { | ||
| "coreFx.Test.netcore50": {}, |
There was a problem hiding this comment.
you will need to add corefx.Test.netcoreapp1.1 to get your netstandard17 test configuration to run.
| <TestTFMs>netcore50;net46</TestTFMs> | ||
| <OSGroup>Windows_NT</OSGroup> | ||
| </Project> | ||
| <Project Include="System.Diagnostics.Tools.Tests.csproj"> |
Commit migrated from dotnet/corefx@277f031
6 participants
Fixes #10685
@ericstj is there any meta file that I missed editing?