Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/Microsoft.Private.PackageBaseline/packageIndex.json
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@
"AssemblyVersionInPackageVersion": {
"4.0.0.0": "4.0.0",
"4.0.1.0": "4.0.1",
"4.0.2.0": "4.3.0"
"4.1.0.0": "4.3.0"
}
},
"System.Diagnostics.TraceSource": {
Expand Down
2 changes: 1 addition & 1 deletion src/System.Diagnostics.Tools/dir.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\dir.props" />
<PropertyGroup>
<AssemblyVersion>4.0.2.0</AssemblyVersion>
<AssemblyVersion>4.1.0.0</AssemblyVersion>
</PropertyGroup>
</Project>

Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
<ItemGroup>
<ProjectReference Include="..\ref\System.Diagnostics.Tools.csproj">
<SupportedFramework>net45;netcore45;netcoreapp1.0;wp8;wpa81;$(AllXamarinFrameworks)</SupportedFramework>
<SupportedFramework>net463;netcoreapp1.1;$(AllXamarinFrameworks)</SupportedFramework>
</ProjectReference>
<ProjectReference Include="any\System.Diagnostics.Tools.pkgproj" />
<ProjectReference Include="aot\System.Diagnostics.Tools.pkgproj" />
<ProjectReference Include="..\src\System.Diagnostics.Tools.csproj">
<TargetGroup>net463</TargetGroup>
</ProjectReference>
<InboxOnTargetFramework Include="MonoAndroid10" />
<InboxOnTargetFramework Include="MonoTouch10" />
<InboxOnTargetFramework Include="net45">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,5 @@
<PreventImplementationReference>true</PreventImplementationReference>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\System.Diagnostics.Tools.csproj">
<TargetGroup>netcore50aot</TargetGroup>
</ProjectReference>
</ItemGroup>

<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
</Project>
4 changes: 4 additions & 0 deletions src/System.Diagnostics.Tools/ref/System.Diagnostics.Tools.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ public GeneratedCodeAttribute(string tool, string version) { }
}
namespace System.Diagnostics.CodeAnalysis
{
[System.AttributeUsageAttribute((System.AttributeTargets)748, Inherited=false, AllowMultiple=false)]
public sealed partial class ExcludeFromCodeCoverageAttribute : System.Attribute {
public ExcludeFromCodeCoverageAttribute() { }
}
[System.AttributeUsageAttribute((System.AttributeTargets)(32767), Inherited = false, AllowMultiple = true)]
[System.Diagnostics.ConditionalAttribute("CODE_ANALYSIS")]
public sealed partial class SuppressMessageAttribute : System.Attribute
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
<PropertyGroup>
<AssemblyVersion>4.0.0.0</AssemblyVersion>
<OutputType>Library</OutputType>
<NuGetTargetMoniker>.NETStandard,Version=v1.0</NuGetTargetMoniker>
<NuGetTargetMoniker>.NETStandard,Version=v1.7</NuGetTargetMoniker>
</PropertyGroup>
<ItemGroup>
<Compile Include="System.Diagnostics.Tools.cs" />
Expand Down
8 changes: 2 additions & 6 deletions src/System.Diagnostics.Tools/ref/project.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
{
"dependencies": {
"System.Runtime": "4.0.0"
"System.Runtime": "4.1.0"
},
"frameworks": {
"netstandard1.0": {
"imports": [
"dotnet5.1"
]
}
"netstandard1.7": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,8 @@
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
<ItemGroup>
<Project Include="System.Diagnostics.Tools.csproj" />
<!-- Net46 facade is currently inbox for 4.0
<Project Include="System.Diagnostics.Tools.csproj">
<TargetGroup>net46</TargetGroup>
</Project> -->
<Project Include="System.Diagnostics.Tools.csproj">
<TargetGroup>netcore50aot</TargetGroup>
<TargetGroup>net463</TargetGroup>
</Project>
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.traversal.targets))\dir.traversal.targets" />
Expand Down
20 changes: 9 additions & 11 deletions src/System.Diagnostics.Tools/src/System.Diagnostics.Tools.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,25 @@
<ProjectGuid>{0B68298B-4672-4CA0-AD25-2F9ABEA1FF95}</ProjectGuid>
<AssemblyName>System.Diagnostics.Tools</AssemblyName>
<IsPartialFacadeAssembly>true</IsPartialFacadeAssembly>
<NuGetTargetMoniker Condition="'$(TargetGroup)' == ''">.NETStandard,Version=v1.3</NuGetTargetMoniker>
<NuGetTargetMoniker Condition="'$(TargetGroup)' == ''">.NETStandard,Version=v1.7</NuGetTargetMoniker>
</PropertyGroup>
<!-- Help VS understand available configurations -->
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net46_Debug|AnyCPU'" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net46_Release|AnyCPU'" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netcore50aot_Debug|AnyCPU'" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netcore50aot_Release|AnyCPU'" />
<ItemGroup Condition="'$(TargetGroup)' == '' Or '$(TargetGroup)' == 'net46'">
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net463_Debug|AnyCPU'" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'net463_Release|AnyCPU'" />
<ItemGroup Condition="'$(TargetGroup)' == '' Or '$(TargetGroup)' == 'net463'">
<TargetingPackReference Include="mscorlib" />
</ItemGroup>
<ItemGroup Condition="'$(TargetGroup)' == 'net46'">
<ItemGroup Condition="'$(TargetGroup)' == 'net463'">
<TargetingPackReference Include="System" />
</ItemGroup>
<ItemGroup Condition="'$(TargetGroup)' == 'netcore50aot'">
<TargetingPackReference Include="System.Private.CoreLib" />
</ItemGroup>
<ItemGroup Condition="'$(TargetGroup)' != 'net46'">
<ItemGroup Condition="'$(TargetGroup)' != 'net463'">
<Compile Include="System\CodeDom\Compiler\GeneratedCodeAttribute.cs" />
</ItemGroup>
<ItemGroup>
<Compile Include="System\Diagnostics\CodeAnalysis\ExcludeFromCodeCoverageAttribute.cs" />
</ItemGroup>
<ItemGroup>
<None Include="project.json" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

namespace System.Diagnostics.CodeAnalysis
{
[AttributeUsageAttribute(AttributeTargets.Class | AttributeTargets.Struct | AttributeTargets.Constructor | AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Event, Inherited = false, AllowMultiple = false)]
public sealed class ExcludeFromCodeCoverageAttribute: Attribute
{
public ExcludeFromCodeCoverageAttribute()
{ }
}
}
14 changes: 3 additions & 11 deletions src/System.Diagnostics.Tools/src/project.json
Original file line number Diff line number Diff line change
@@ -1,21 +1,13 @@
{
"frameworks": {
"netstandard1.3": {
"netstandard1.7": {
"dependencies": {
"Microsoft.TargetingPack.Private.CoreCLR": "1.2.0-beta-24530-04"
},
"imports": [
"dotnet5.4"
]
},
"net46": {
"dependencies": {
"Microsoft.TargetingPack.NETFramework.v4.6": "1.0.1"
}
},
"netcore50": {
"net463": {
"dependencies": {
"Microsoft.TargetingPack.Private.NETNative": "1.1.0-beta-24530-00"
"Microsoft.TargetingPack.NETFramework.v4.6": "1.0.1"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
<ItemGroup>
<Project Include="System.Diagnostics.Tools.Tests.csproj"/>
<Project Include="System.Diagnostics.Tools.Tests.csproj"/>
<Project Include="System.Diagnostics.Tools.Tests.csproj">
<TestTFMs>netcore50;net46</TestTFMs>
<OSGroup>Windows_NT</OSGroup>
</Project>
<Project Include="System.Diagnostics.Tools.Tests.csproj">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joperezr you are going to need to pick-up this change with your PR #12241.

<TargetGroup>netstandard1.7</TargetGroup>
<TestTFMs>netcoreapp1.1</TestTFMs>
</Project>
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.traversal.targets))\dir.traversal.targets" />
</Project>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<OutputType>Library</OutputType>
<RootNamespace>System</RootNamespace>
<AssemblyName>System.Diagnostics.Tools.Tests</AssemblyName>
<NugetTargetMoniker>.NETStandard,Version=v1.3</NugetTargetMoniker>
<NugetTargetMoniker Condition="'$(TargetGroup)' == ''">.NETStandard,Version=v1.3</NugetTargetMoniker>
</PropertyGroup>
<!-- Default configurations to help VS understand the configurations -->
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'" />
Expand All @@ -17,13 +17,12 @@
<Compile Include="System\CodeDom\Compiler\GeneratedCodeAttributeTests.cs" />
<Compile Include="System\Diagnostics\CodeAnalysis\SuppressMessageAttributeTests.cs" />
</ItemGroup>
<ItemGroup Condition="'$(TargetGroup)'=='netstandard1.7'">
<Compile Include="System\Diagnostics\CodeAnalysis\ExcludeFromCodeCoverageAttributeTests.cs" />
</ItemGroup>
<ItemGroup>
<!-- Compile tests against the contract, but copy our local-built implementation for testing -->
<ProjectReference Include="..\pkg\System.Diagnostics.Tools.pkgproj">
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
<OutputItemType>Content</OutputItemType>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Targets>Build;DebugSymbolsProjectOutputGroup</Targets>
<ProjectReference Include="..\pkg\System.Diagnostics.Tools.pkgproj">
</ProjectReference>
</ItemGroup>
<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Diagnostics.CodeAnalysis;
using Xunit;

namespace System.Diagnostics.CodeAnalysis.Tests
{
public class ExcludeFromCodeCoverageAttributeTests
{
[Fact]
public void ExcludeFromCodeCoverageAttribute_Instantiate()
{
new ExcludeFromCodeCoverageAttribute();
}
}
}
3 changes: 2 additions & 1 deletion src/System.Diagnostics.Tools/tests/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"Microsoft.DotNet.BuildTools.TestSuite": "1.0.0-prerelease-00807-03"
},
"frameworks": {
"netstandard1.3": {}
"netstandard1.3": {},
"netstandard1.7": {}
},
"supports": {
"coreFx.Test.netcore50": {},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to add corefx.Test.netcoreapp1.1 to get your netstandard17 test configuration to run.

Expand Down