Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add '--testTFM' option and set default to netcoreapp1.1 in run-test.sh#12440

Merged
stephentoub merged 1 commit intodotnet:masterfrom
hseok-oh:fix_TestTFM
Oct 11, 2016
Merged

Add '--testTFM' option and set default to netcoreapp1.1 in run-test.sh#12440
stephentoub merged 1 commit intodotnet:masterfrom
hseok-oh:fix_TestTFM

Conversation

@hseok-oh
Copy link
Copy Markdown

@hseok-oh hseok-oh commented Oct 7, 2016

By #12241, netcoreapp1.1 become new default TestTFM for all project.
We need to change default netcoreapp1.0 to 1.1, and add new option to set TestTFM

@stephentoub
Copy link
Copy Markdown
Member

cc: @weshaggard

@weshaggard
Copy link
Copy Markdown
Member

I'm not sure what context this run-test.sh script is used in anymore. We have moved to using build.sh for all our builds. @hseok-oh what context are you using this script where the default build.sh scripts don't work? Is this for a platform that doesn't have a supported CLI yet? @ellismg are you aware of any contexts where we still use run-tests.sh?

@weshaggard
Copy link
Copy Markdown
Member

(sorry accidentally hit the close button)

@hseok-oh
Copy link
Copy Markdown
Author

hseok-oh commented Oct 10, 2016

@weshaggard It needs for ARM 32 bit with linux, such as Raspberry Pi 2 or 3. We need to build CoreCLR and CoreFX using cross compilation in x64(or x86) linux, install to target machine, and test.

@ellismg
Copy link
Copy Markdown
Contributor

ellismg commented Oct 10, 2016

As @hseok-oh this is used in cross build scinerios, for ARM.

@weshaggard
Copy link
Copy Markdown
Member

I'm fine with this option being included but I do think we need to figure out how to improve this script and unify it with the way we do testing for our other platforms. Right now it is making some assumptions that are very fragile and will likely break often.

@hseok-oh hseok-oh deleted the fix_TestTFM branch October 24, 2016 03:05
@karelz karelz modified the milestone: 1.2.0 Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Add '--testTFM' option and set default to netcoreapp1.1 in run-test.sh

Commit migrated from dotnet/corefx@24df3d3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants