Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Change '--testTFM' option to '--testRelPath' and default value in run-test.sh#12946

Merged
stephentoub merged 1 commit intodotnet:masterfrom
hseok-oh:fix_testPath
Oct 25, 2016
Merged

Change '--testTFM' option to '--testRelPath' and default value in run-test.sh#12946
stephentoub merged 1 commit intodotnet:masterfrom
hseok-oh:fix_testPath

Conversation

@hseok-oh
Copy link
Copy Markdown

Similar issue with #12440
Test path changed by #12634 (dotnet/buildtools#1121)

  • Change option name of --testTFM to --testRelPath to set relative path from project directory to test script.
  • Set default value to default.netcoreapp1.1/netcoreapp1.1

cc/ @weshaggard @stephentoub

@stephentoub
Copy link
Copy Markdown
Member

@dotnet-bot Test Innerloop Linux ARM Emulator Release Cross Build please (package restore failure)

@hseok-oh
Copy link
Copy Markdown
Author

@dotnet-bot Test Innerloop Linux ARM Emulator Release Cross Build and Test please

@hseok-oh
Copy link
Copy Markdown
Author

@dotnet-bot Test Innerloop OSX Debug Build and Test please

@hseok-oh
Copy link
Copy Markdown
Author

@dotnet-bot Test Innerloop Linux ARM Emulator Release Cross Build and Test please

@weshaggard
Copy link
Copy Markdown
Member

cc @joperezr

The change looks OK but I will still say we need a better way than needing to manually update this script. We will likely be breaking it more some changes to come.

@hseok-oh
Copy link
Copy Markdown
Author

@dotnet-bot Test Innerloop Linux ARM Emulator Release Cross Build and Test please (package restore failure)

@joperezr
Copy link
Copy Markdown
Member

The change looks OK but I will still say we need a better way than needing to manually update this script. We will likely be breaking it more some changes to come.

I agree. Actually we will break it soon when we move master to netcoreapp1.2 as we will be changing all of the defaults there. In general, we have tried to avoid having the same logic/setting on two places so that we can make changes in a single place.

@stephentoub stephentoub merged commit 1bf0009 into dotnet:master Oct 25, 2016
@hseok-oh hseok-oh deleted the fix_testPath branch October 26, 2016 09:42
@karelz karelz modified the milestone: 1.2.0 Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants