Change '--testTFM' option to '--testRelPath' and default value in run-test.sh#12946
Change '--testTFM' option to '--testRelPath' and default value in run-test.sh#12946stephentoub merged 1 commit intodotnet:masterfrom hseok-oh:fix_testPath
Conversation
|
@dotnet-bot Test Innerloop Linux ARM Emulator Release Cross Build please (package restore failure) |
|
@dotnet-bot Test Innerloop Linux ARM Emulator Release Cross Build and Test please |
|
@dotnet-bot Test Innerloop OSX Debug Build and Test please |
|
@dotnet-bot Test Innerloop Linux ARM Emulator Release Cross Build and Test please |
|
cc @joperezr The change looks OK but I will still say we need a better way than needing to manually update this script. We will likely be breaking it more some changes to come. |
|
@dotnet-bot Test Innerloop Linux ARM Emulator Release Cross Build and Test please (package restore failure) |
I agree. Actually we will break it soon when we move master to netcoreapp1.2 as we will be changing all of the defaults there. In general, we have tried to avoid having the same logic/setting on two places so that we can make changes in a single place. |
Similar issue with #12440
Test path changed by #12634 (dotnet/buildtools#1121)
--testTFMto--testRelPathto set relative path from project directory to test script.default.netcoreapp1.1/netcoreapp1.1cc/ @weshaggard @stephentoub