Add System.Diagnostics.StackTrace to test runtime dependencies#12567
Add System.Diagnostics.StackTrace to test runtime dependencies#12567tmat merged 1 commit intodotnet:masterfrom
Conversation
|
This fixes the lack-of-line-numbers-in-exception-stack-traces problem? If so, excellent! |
|
LGTM. I would only want to consult with @ericstj and make sure that including this by default with all tests is not going to be an issue (i.e. it may need to be specificallly included only in certain groups) |
|
@stephentoub Yes. Seems like it should. |
|
test Innerloop Ubuntu14.04 Debug Build and Test please |
|
test Innerloop Ubuntu14.04 Release Build and Test please |
|
@tmat , with the dependency-versioning issue fixed, it's clear that there is a serious effect (at least to logging?) of including this DLL on Ubuntu runs. We'll need to figure that out (may be a product issue) before you can merge, as this will affect all tests running on Ubuntu all the time. *Update: This problem is only in logging and thus may not be a major issue. It definitely seems to make the CI logs very, very long for certain tests. |
We need to either remove the assert that's getting triggered, or remove the tests that are hitting the assert. I'd prefer the former: if it's possible to hit an assert from a test, assuming it's via publicly exposed surface area, then either there's a bug in the implementation or the assert is invalid. |
|
Agreed, I pinged @jamesqo in his PR that added these. |
|
Sorry for this. Fixed the issue in #12599 by removing the relevant tests |
|
OK, I'll wait for #12599 before merging this. |
It's been merged. Though due to other things having been merged you're unfortunately going to need to rebase to address a merge conflict. |
7 participants
The library was missing from test output directory, which prevented xunit to display stack traces with source locations.