This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove all Throws* tests from ArrayBuilderTests#12599
Merged
stephentoub merged 1 commit intodotnet:masterfrom Oct 12, 2016
Merged
Remove all Throws* tests from ArrayBuilderTests#12599stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
Member
|
Looks ok to me. Make sure to check the build logs from Ubuntu Debug to confirm its fixed. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…assert Remove all Throws* tests from ArrayBuilderTests Commit migrated from dotnet/corefx@757a6dc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ericstj mentioned in #12567 that there was a lot of build spew being generated from hitting debug asserts, even though they were wrapped in
ThrowsAnyclauses. This PR removes them.cc @ericstj, @stephentoub, @MattGal