Expose BufferedStream UnderlyingStream and BufferSize properties#12569
Expose BufferedStream UnderlyingStream and BufferSize properties#12569jkotas merged 1 commit intodotnet:masterfrom
Conversation
|
@dotnet-bot test Innerloop Ubuntu14.04 Debug Build and Test please |
| if (adapterExists) | ||
| { | ||
| Debug.Assert((adapter is BufferedStreamWrapper && ((BufferedStreamWrapper)adapter).UnderlyingStream is WinRtToNetFxStreamAdapter) | ||
| Debug.Assert((adapter is BufferedStream && ((BufferedStream)adapter).UnderlyingStream is WinRtToNetFxStreamAdapter) |
There was a problem hiding this comment.
Given that you made the API netcoreapp1.1 specific I don't expect that this code can actually call it as it isn't compiled for netcoreapp1.1. I suspect you are actually still using the internal version of this API in System.Private.CoreLib which I pointed out to @luqunl in his PR but it doesn't look like he fixed.
There was a problem hiding this comment.
The .csproj file is referencing the System.IO implementation - the implementation always has this member.
Yes, the CoreCLR build is still using CoreLib version of BufferedStream. It is not easy to fix in corefx because of name collisions. I plan to remove BufferedStream from CoreLib and then fix it.
|
@dotnet-bot test Innerloop Ubuntu14.04 Debug Build and Test please |
…net/corefx#12569) Fix dotnet/corefx#12356 Commit migrated from dotnet/corefx@be874f8
5 participants
Fix #12356