This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Implement generic interfaces on Regex collections for netcoreapp1.1#12596
Merged
Priya91 merged 4 commits intodotnet:masterfrom Oct 13, 2016
Merged
Implement generic interfaces on Regex collections for netcoreapp1.1#12596Priya91 merged 4 commits intodotnet:masterfrom
Priya91 merged 4 commits intodotnet:masterfrom
Conversation
justinvp
force-pushed
the
regex_collections
branch
2 times, most recently
from
248c3ee to
4325d7f
Compare
It conflicts with the actual `System.Text.RegularExpressions.Capture` type.
Implement IList<T>, IReadOnlyList<T>, and IList on the Regex collections. Expose the new APIs in netcoreapp1.1.
justinvp
force-pushed
the
regex_collections
branch
from
4325d7f to
8b0f3fa
Compare
Priya91
reviewed
Oct 13, 2016
| <OutputType>Library</OutputType> | ||
| <NuGetTargetMoniker>.NETStandard,Version=v1.7</NuGetTargetMoniker> | ||
| <DefineConstants Condition="'$(TargetGroup)' == 'netcoreapp1.1'">$(DefineConstants);netcoreapp11</DefineConstants> | ||
| </PropertyGroup> |
Contributor
There was a problem hiding this comment.
Instead of defining constant, can you add separate file with partial class that's included only for netcoreapp1.1, that way it's more readable, given the number of additions.
Contributor
Author
There was a problem hiding this comment.
I was just following the same convention used by all these other netcoreapp1.1 PRs, which define this constant instead of adding new partial ref .cs file:
- Expose new .netcoreapp1.1 APIs in System.Runtime #12226
- Expose GC.GetAllocatedBytesForCurrentThread in netcoreapp1.1 #12489
- Add RuntimeHelpers.GetUninitializedObject for netcoreapp1.1 #12482
- Expose BufferedStream UnderlyingStream and BufferSize properties #12569
- Expose new String.Split overloads in netcoreapp1.1 #12495
Let me know if you still prefer the separate file here.
Contributor
There was a problem hiding this comment.
Yes please, the other additions are less lines of code so #if statements are fine. That's not the case here.
Contributor
Author
|
Thanks for the review, @Priya91. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Implement generic interfaces on Regex collections for netcoreapp1.1 Commit migrated from dotnet/corefx@6403321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #1756 from Future to Master and expose the new APIs for netcoreapp1.1.
Part of #2869