Remove unnecessary unsafe code flag.#13
Remove unnecessary unsafe code flag.#13dotnet-bot merged 1 commit intodotnet:masterfrom AArnott:FixUnsafeCodeWarning
Conversation
The Immutable PCL targets platforms that include those that don't support unsafe code. Opening the solution in VS2015 results in a warning in the error list about this. But features that required unsafe code were recently removed so we don't need this flag any more.
|
If you notice the whitespace changes in the project file, they're natural from just saving the project in VS. So this project file was hand-edited and should (IMO) just be reverted to what VS saves by default so that we don't have to fight these whitespace changes with every checkin. |
|
This is semi-related, but I get another warning when opening this in VS relating to one of the resx designer files. Given that you're fixing up the csproj, it might make sense to fix this as well since the project would open clean in VS then. The second line should just be |
|
@mellinoe FWIW, I am pretty sure all that ValidationStrings stuff is dead code. I am preparing a PR that's just going to remove the whole thing. |
|
Ah, well if that's the case then we might as well just remove it. 👍 |
|
@Anipik why did you change the milestone? Was it possibly mishap of the labeling tooling? |
|
yes it was mishap of the labeling tool. |
|
Thanks for confirmation! |
The Immutable PCL targets platforms that include those that don't support unsafe code. Opening the solution in VS2015 results in a warning in the error list about this. But features that required unsafe code were recently removed so we don't need this flag any more.