Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Remove unnecessary unsafe code flag.#13

Merged
dotnet-bot merged 1 commit intodotnet:masterfrom
AArnott:FixUnsafeCodeWarning
Nov 11, 2014
Merged

Remove unnecessary unsafe code flag.#13
dotnet-bot merged 1 commit intodotnet:masterfrom
AArnott:FixUnsafeCodeWarning

Conversation

@AArnott
Copy link
Copy Markdown

@AArnott AArnott commented Nov 11, 2014

The Immutable PCL targets platforms that include those that don't support unsafe code. Opening the solution in VS2015 results in a warning in the error list about this. But features that required unsafe code were recently removed so we don't need this flag any more.

The Immutable PCL targets platforms that include those that don't support unsafe code. Opening the solution in VS2015 results in a warning in the error list about this. But features that required unsafe code were recently removed so we don't need this flag any more.
@AArnott
Copy link
Copy Markdown
Author

AArnott commented Nov 11, 2014

If you notice the whitespace changes in the project file, they're natural from just saving the project in VS. So this project file was hand-edited and should (IMO) just be reverted to what VS saves by default so that we don't have to fight these whitespace changes with every checkin.

@mellinoe
Copy link
Copy Markdown
Contributor

This is semi-related, but I get another warning when opening this in VS relating to one of the resx designer files. Given that you're fixing up the csproj, it might make sense to fix this as well since the project would open clean in VS then.

<Compile Include="Validation\ValidationStrings.Designer.cs">
  <DependentUpon>Validation\ValidationStrings.resx</DependentUpon>

The second line should just be

    <DependentUpon>ValidationStrings.resx</DependentUpon>.

@ellismg
Copy link
Copy Markdown
Contributor

ellismg commented Nov 11, 2014

@mellinoe FWIW, I am pretty sure all that ValidationStrings stuff is dead code. I am preparing a PR that's just going to remove the whole thing.

@mellinoe
Copy link
Copy Markdown
Contributor

Ah, well if that's the case then we might as well just remove it. 👍

@dotnet-bot dotnet-bot merged commit e489e95 into dotnet:master Nov 11, 2014
@AArnott AArnott deleted the FixUnsafeCodeWarning branch November 11, 2014 23:51
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
@Anipik Anipik removed this from the 1.0.0-rtm milestone Sep 21, 2018
@karelz karelz added this to the 1.0.0-rtm milestone Nov 15, 2018
@karelz
Copy link
Copy Markdown
Member

karelz commented Nov 15, 2018

@Anipik why did you change the milestone? Was it possibly mishap of the labeling tooling?

@Anipik
Copy link
Copy Markdown

Anipik commented Nov 15, 2018

yes it was mishap of the labeling tool.

@karelz
Copy link
Copy Markdown
Member

karelz commented Nov 15, 2018

Thanks for confirmation!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants