Enable armel for CI script#14843
Conversation
Signed-off-by: chunseoklee <chunseok.lee@samsung.com>
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
|
This patch relates to https://github.com/dotnet/core-setup/issues/725 |
chunseoklee
changed the title
karelz
added
area-Infrastructure-libraries
arch-arm32
os-linux
| #Apply the changes needed to build for the emulator rootfs | ||
| (set +x; echo 'Applying cross build patch to suit Linux ARM emulator rootfs') | ||
| git am < "$__ARMRootfsMountPath"/dotnet/setenv/corefx_cross.patch | ||
| #(set +x; echo 'Applying cross build patch to suit Linux ARM emulator rootfs') |
There was a problem hiding this comment.
Can you please remove the commented out lines if they are no longer required?
There was a problem hiding this comment.
removed as you commented.
| @@ -212,7 +212,7 @@ do | |||
| ;; | |||
| --softfp) | |||
There was a problem hiding this comment.
Why dont we change the -softfp to armel as well for consistency?
There was a problem hiding this comment.
I agree with you.
It seems that -softfp option is passed by CI. To modify this name, we have to modify CI trigger command as well.
There was a problem hiding this comment.
I found that we can modify -softfp in corefx/netci.groovy script.
I will update the last patch again soon.
Signed-off-by: chunseoklee <chunseok.lee@samsung.com>
Signed-off-by: chunseoklee <chunseok.lee@samsung.com>
|
@chunseoklee I've updated #14844 not to modify toolchain.cmake :) |
| echo ' Any other value is not accepted' | ||
| echo 'Optional Arguments:' | ||
| echo ' --softfp : Build as arm-softfp' | ||
| echo ' --armel : Build as armel' |
There was a problem hiding this comment.
nit: Spacing looks off by 1
There was a problem hiding this comment.
fixed as you commented
|
@chunseoklee Is this ready to merge? |
|
Except mellinoe's comment, it is ready to merge. |
|
@chunseoklee Let me know when that is fixed and I will merge the change. |
1. This patch removes tizen version number from cross/armel/toolchain.cmake. 2. indentation fix Signed-off-by: chunseoklee <chunseok.lee@samsung.com>
|
@gkhanna79 ready to merged. Thank you ! |
Fix corefx directory: arm-softfp to armel related PR: dotnet/corefx#14843
Enable armel for CI script Commit migrated from dotnet/corefx@f053a6c
7 participants
Signed-off-by: chunseoklee chunseok.lee@samsung.com