Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add Tizen rootfs for armel#14844

Merged
gkhanna79 merged 1 commit into
dotnet:masterfrom
hqueue:arm/rootfs/tizen
Jan 5, 2017
Merged

Add Tizen rootfs for armel#14844
gkhanna79 merged 1 commit into
dotnet:masterfrom
hqueue:arm/rootfs/tizen

Conversation

@hqueue
Copy link
Copy Markdown
Member

@hqueue hqueue commented Jan 4, 2017

Add a Tizen rootfs for armel and most of this commit is copied from CoreCLR.

Signed-off-by: Hyung-Kyu Choi hk0110.choi@samsung.com

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 4, 2017

This is a part of core-setup issue "Enabling Linux ARM32 for .NET Core" dotnet/core-setup#725 .

Comment thread cross/build-rootfs.sh Outdated
__UbuntuRepo="http://ftp.debian.org/debian/"
;;
tizen)
if [ "$__BuildArch" != "arm-softfp" ]; then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt this be armel?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkhanna79 Thanks! I've updated it. And also change error message to "Unsupported target platform." as you suggested in CoreCLR.

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 5, 2017

@gkhanna79 @mellinoe PTAL Update PR with feedback and all CI tests are passed.

Add a Tizen rootfs for armel and most of this commit is copied from CoreCLR.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
@hqueue hqueue force-pushed the arm/rootfs/tizen branch 2 times, most recently from 6cb0b81 to f6fae52 Compare January 5, 2017 08:08
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 5, 2017

@gkhanna79 I've updated PR with your feedback and minor addtion. PTAL thanks.

@gkhanna79
Copy link
Copy Markdown
Member

@hqueue LGTM. Can these be merged?

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 5, 2017

@gkhanna79 Yes, please merge this :)

@gkhanna79 gkhanna79 merged commit 6b74b72 into dotnet:master Jan 5, 2017
@karelz karelz modified the milestone: 2.0.0 Jan 12, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants