This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Ensure dynamic method is not inlined#16069
Closed
gkhanna79 wants to merge 1 commit into
Closed
Conversation
Member
|
This is not the right fix for the problem. The caller of Assembly.Load is not supposed to be inlined. It is a bug that was likely introduced by dotnet/coreclr#9491 |
gkhanna79
added
the
* NO MERGE *
Member
Author
|
Closing in favor of dotnet/coreclr#9537 that fixes the inlining issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that dynamically emitted method for the load context RefEmit tests do not get inlined or optimized out.
Fixes issues like #16064 (comment)
CC @stephentoub @jkotas