Use DynamicSecurityMethod attribute to mark methods with StackCrawlMark#9491
Conversation
|
This error message that was fixed yesterday by @AndyAyersMS is now wrong, again, right? |
|
I feel I should ask if the Jit changes will break on desktop; but have no idea about the relationship between the code bases to know if that's a valid question. |
|
The part shared with desktop is https://github.com/dotnet/coreclr/tree/master/src/jit . There are no changes in this part. |
Yes, the original message was more accurate. I will revert it. |
|
LGTM. Nice to have this finally ironed out. |
This reverts commit 0826f9d.
CoreCLR does not have CAS, and so we can conveniently use it to mark methods with StackCrawlMark to decouple it from NoInlining. The original purpose of DynamicSecurityMethod was to disable inlining of the caller and to insert CAS security checks, so we are basically just keeping the first part. Fixes #8102
|
Nice! This will be useful in a bunch of places, e.g. |
Use DynamicSecurityMethod attribute to mark methods with StackCrawlMark Commit migrated from dotnet/coreclr@e5f2df2
6 participants
CoreCLR does not have CAS, and so we can conveniently use it to mark methods with StackCrawlMark to
decouple it from NoInlining. The original purpose of DynamicSecurityMethod was to disable inlining
of the caller and to insert CAS security checks, so we are basically just keeping the first part.
Fixes #8102