This repository was archived by the owner on Jan 23, 2023. It is now read-only.
NoInlining Indirect for NotifyOfCrossThreadDependencySlow#9490
Closed
benaadams wants to merge 1 commit into
Closed
NoInlining Indirect for NotifyOfCrossThreadDependencySlow#9490benaadams wants to merge 1 commit into
benaadams wants to merge 1 commit into
Conversation
To avoid the stackcrawlmark interpretation side effect
Member
|
I am fixing this for good in #9491 |
Member
|
@jkotas, this can be closed then with your change, right? |
Member
Author
|
I hope so 😄 |
Member
|
Right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid the stackcrawlmark interpretation side effect
Debugger.NotifyOfCrossThreadDependency();can't be inlined becauseDebugger:NotifyOfCrossThreadDependencySlowis marked as NoInlining; which in mscorlib means it has a StackCrawMark which means its caller also won't be inlined. This bail is then baked into the NGen image.So currently AsyncTaskMethodBuilder has to call into it, rather than inline the check