Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Use x64 nupkgs on armel build and arm nupkgs on arm build#16139

Merged
stephentoub merged 1 commit into
dotnet:masterfrom
jyoungyun:armel/workaround_x64_nupkgs
Feb 14, 2017
Merged

Use x64 nupkgs on armel build and arm nupkgs on arm build#16139
stephentoub merged 1 commit into
dotnet:masterfrom
jyoungyun:armel/workaround_x64_nupkgs

Conversation

@jyoungyun
Copy link
Copy Markdown
Contributor

Force external pakcages to be restored for x64 until armel packages are fully broughtup

Related issue : #15900

Force external pakcages to be restored for x64 until armel packages are fully broughtup

Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
@jyoungyun
Copy link
Copy Markdown
Contributor Author

@dotnet-bot please test Innerloop Windows_NT Debug Build and Test

@jyoungyun
Copy link
Copy Markdown
Contributor Author

jyoungyun commented Feb 14, 2017

@hqueue
Copy link
Copy Markdown
Member

hqueue commented Feb 14, 2017

@jyoungyun And it also enables arm restores package from NuGet server right ?

@jyoungyun
Copy link
Copy Markdown
Contributor Author

@hqueue Yes, right. CoreFX has a NuGet.config file in itself and the config file refers to dotnet-core myget. All arm nupkgs were uploaded to dotnet-core myget so I removed workaround codes on arm build. But armel does not setup yet so I added workaround patch for armel build.

@hqueue
Copy link
Copy Markdown
Member

hqueue commented Feb 14, 2017

LGTM

@stephentoub stephentoub merged commit 939b99d into dotnet:master Feb 14, 2017
@gkhanna79
Copy link
Copy Markdown
Member

@weshaggard You were planning to add a switch to suppress this restoration and thus, avoid having such changes. When do you think that will come through?

@weshaggard
Copy link
Copy Markdown
Member

Yes I have issue https://github.com/dotnet/corefx/issues/15503 tracking that but I haven't gotten that just yet. I doubt I will be able to get to it this week but hopefully I will get to it next week but for now this workaround seems reasonable to me.

@hqueue
Copy link
Copy Markdown
Member

hqueue commented Feb 15, 2017

This fixes issue #15519.

weshaggard added a commit to weshaggard/corefx that referenced this pull request Feb 22, 2017
@karelz karelz modified the milestone: 2.0.0 Feb 22, 2017
weshaggard added a commit to weshaggard/corefx that referenced this pull request Feb 23, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…d_x64_nupkgs

Use x64 nupkgs on armel build and arm nupkgs on arm build

Commit migrated from dotnet/corefx@939b99d
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants