Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Updating Buildtools so that we use Compiler server on non-Windows#28272

Merged
stephentoub merged 1 commit into
dotnet:masterfrom
joperezr:UpdateBT
Mar 21, 2018
Merged

Updating Buildtools so that we use Compiler server on non-Windows#28272
stephentoub merged 1 commit into
dotnet:masterfrom
joperezr:UpdateBT

Conversation

@joperezr
Copy link
Copy Markdown
Member

fixes #27510

Updating Buildtools.

@joperezr
Copy link
Copy Markdown
Member Author

This also fixes: dotnet/buildtools#1899

@stephentoub
Copy link
Copy Markdown
Member

I see you addressed the case default issue here as well. Thankfully we made the same fix so there's no conflict :)

@stephentoub stephentoub merged commit d747c95 into dotnet:master Mar 21, 2018
switch (standardFormat)
{
case (default):
case default(char):
Copy link
Copy Markdown

@ahsonkhan ahsonkhan Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VSadov, why was this change necessary as part of the compiler update? case (default) compiled previously.

Is this a known breaking change?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joperezr joperezr deleted the UpdateBT branch March 21, 2018 15:40
@karelz karelz added this to the 2.1.0 milestone Mar 27, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux builds have increased in time beyond 1 hour average; needs investigation

4 participants