Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Updating Buildtools so that we use Compiler server on non-Windows #28272

Merged
stephentoub merged 1 commit into from
Mar 21, 2018
Merged

Updating Buildtools so that we use Compiler server on non-Windows #28272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BuildToolsVersion.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.1.0-preview3-02620-05
2.1.0-preview3-02620-10
6 changes: 3 additions & 3 deletions dependencies.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<ProjectNTfsTestILCCurrentRef>75673f211690f5a9df7447e547e5b520bddfd33a</ProjectNTfsTestILCCurrentRef>
<SniCurrentRef>8bd1ec5fac9f0eec34ff6b34b1d878b4359e02dd</SniCurrentRef>
<StandardCurrentRef>6298244e25cf84d91e3cda9627315f2425274624</StandardCurrentRef>
<BuildToolsCurrentRef>2a49ae275b2058102069dd364357ebac013de944</BuildToolsCurrentRef>
<BuildToolsCurrentRef>91233f5f85ad8dc86ee7052672e19d6af3f02f79</BuildToolsCurrentRef>
</PropertyGroup>

<!-- Product dependency versions. -->
Expand Down Expand Up @@ -48,13 +48,13 @@
<AppXRunnerVersion>1.0.3-prerelease-00921-01</AppXRunnerVersion>
<XunitPerfAnalysisPackageVersion>1.0.0-beta-build0018</XunitPerfAnalysisPackageVersion>
<TraceEventPackageVersion>2.0.5</TraceEventPackageVersion>
<XunitNetcoreExtensionsVersion>2.1.0-preview3-02620-05</XunitNetcoreExtensionsVersion>
<XunitNetcoreExtensionsVersion>2.1.0-preview3-02620-10</XunitNetcoreExtensionsVersion>
</PropertyGroup>

<!-- Package versions used as toolsets -->
<PropertyGroup>
<FeedTasksPackage>Microsoft.DotNet.Build.Tasks.Feed</FeedTasksPackage>
<FeedTasksPackageVersion>2.1.0-preview3-02620-05</FeedTasksPackageVersion>
<FeedTasksPackageVersion>2.1.0-preview3-02620-10</FeedTasksPackageVersion>
</PropertyGroup>

<!-- Publish symbol build task package -->
Expand Down
4 changes: 2 additions & 2 deletions src/System.Memory/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Date.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out DateTime value, out int
return true;
}

case (default):
case default(char):
case 'G':
return TryParseDateTimeG(text, out value, out _, out bytesConsumed);

Expand Down Expand Up @@ -132,7 +132,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out DateTimeOffset value, o
case 'O':
return TryParseDateTimeOffsetO(text, out value, out bytesConsumed, out _);

case (default):
case default(char):
return TryParseDateTimeOffsetDefault(text, out value, out bytesConsumed);

case 'G':
Expand Down
2 changes: 1 addition & 1 deletion src/System.Memory/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Decimal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out decimal value, out int
ParseNumberOptions options;
switch (standardFormat)
{
case (default):
case default(char):
case 'G':
case 'g':
case 'E':
Expand Down
2 changes: 1 addition & 1 deletion src/System.Memory/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Float.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ private static bool TryParseNormalAsFloatingPoint(ReadOnlySpan<byte> text, out d
ParseNumberOptions options;
switch (standardFormat)
{
case (default):
case default(char):
case 'G':
case 'g':
case 'E':
Expand Down
2 changes: 1 addition & 1 deletion src/System.Memory/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Guid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out Guid value, out int byt
{
switch (standardFormat)
{
case (default):
case default(char):
case 'D':
return TryParseGuidCore(text, false, ' ', ' ', out value, out bytesConsumed);
case 'B':
Expand Down
8 changes: 4 additions & 4 deletions src/System.Memory/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Integer.Signed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out sbyte value, out int by
{
switch (standardFormat)
{
case (default):
case default(char):
case 'g':
case 'G':
case 'd':
Expand Down Expand Up @@ -87,7 +87,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out short value, out int by
{
switch (standardFormat)
{
case (default):
case default(char):
case 'g':
case 'G':
case 'd':
Expand Down Expand Up @@ -133,7 +133,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out int value, out int byte
{
switch (standardFormat)
{
case (default):
case default(char):
case 'g':
case 'G':
case 'd':
Expand Down Expand Up @@ -179,7 +179,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out long value, out int byt
{
switch (standardFormat)
{
case (default):
case default(char):
case 'g':
case 'G':
case 'd':
Expand Down
8 changes: 4 additions & 4 deletions src/System.Memory/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Integer.Unsigned.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out byte value, out int byt
{
switch (standardFormat)
{
case (default):
case default(char):
case 'g':
case 'G':
case 'd':
Expand Down Expand Up @@ -77,7 +77,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out ushort value, out int b
{
switch (standardFormat)
{
case (default):
case default(char):
Copy link
Copy Markdown

@ahsonkhan ahsonkhan Mar 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VSadov, why was this change necessary as part of the compiler update? case (default) compiled previously.

Is this a known breaking change?

Copy link
Copy Markdown
Member

@stephentoub stephentoub Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/roslyn#23629

case 'g':
case 'G':
case 'd':
Expand Down Expand Up @@ -123,7 +123,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out uint value, out int byt
{
switch (standardFormat)
{
case (default):
case default(char):
case 'g':
case 'G':
case 'd':
Expand Down Expand Up @@ -169,7 +169,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out ulong value, out int by
{
switch (standardFormat)
{
case (default):
case default(char):
case 'g':
case 'G':
case 'd':
Expand Down
2 changes: 1 addition & 1 deletion src/System.Memory/src/System/Buffers/Text/Utf8Parser/Utf8Parser.TimeSpan.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public static bool TryParse(ReadOnlySpan<byte> text, out TimeSpan value, out int
{
switch (standardFormat)
{
case (default):
case default(char):
case 'c':
case 't':
case 'T':
Expand Down