[2.1] Port "Do not expand stacktraces when completion exception is rethrown multiple times"#31680
Conversation
halter73
left a comment
There was a problem hiding this comment.
I just realized this change creates an undesired behavioral change where if you complete a pipe with multiple exceptions, the last exception is now thrown from the other side instead of the first one.
|
I think we'll have to fix this in master too. |
|
I updated this PR to include behaviour fix from #31685 |
|
This is ready to be merged. #31685 fixed tests failures we were seeing in master. |
|
This PR was updated with a regression fix. I'm going to remove NO MERGE label and merge the PR. /cc @joshfree |
|
@pakrym did you get shiproom approval? cc @danmosemsft |
|
I got it for 2.1.4 and then we discovered a regression and postponed merging. |
|
I re-added servicing considered label and would wait for re-approval. |
|
@dotnet-bot test Linux x64 Release Build please |
|
OK re-added consider label. Please update template if necessary. |
|
Approved for 2.1.5 |
Ports #31375 and #31685
Fixes #31388
2.1 template
Description
Multiple calls to ReadAsync on the faulted pipe would produce exceptions with ever-increasing stacktraces.
Customer Impact
Customers would see exceptions with suspiciously long stacktraces:
aspnet/KestrelHttpServer#2745
aspnet/SignalR#2672
Regression?
No
Risk
Only the way we use ExceptionDispatchInfo inside pipe changes. No other logical changes.