This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
halter73
approved these changes
Aug 9, 2018
ahsonkhan
approved these changes
Aug 9, 2018
karaziox
reviewed
Aug 9, 2018
| Pipe.Writer.Complete(); | ||
| Pipe.Writer.Complete(new Exception()); | ||
|
|
||
| var result = await Pipe.Reader.ReadAsync(); |
There was a problem hiding this comment.
Nit, but the tests for ReadAsync are in the FlushAsync file, and the FlushAsync tests in the ReadAsync file.
Author
There was a problem hiding this comment.
I treated FlushAsyncCompletionTests.cs as writer completion tests and these tests are testing reader and writer completion behaviour.
pakrym
added a commit
to pakrym/corefx
that referenced
this pull request
Aug 10, 2018
pakrym
added a commit
to pakrym/corefx
that referenced
this pull request
Aug 10, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@a3060ae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct behaviour is "the first completion wins"
It was regressed in #31375 fix for https://github.com/dotnet/corefx/issues/31388