Added additional OIDs for CMS signatures.#32666
Added additional OIDs for CMS signatures.#32666bartonjs merged 1 commit intodotnet:masterfrom vcsjones:fix-32639
Conversation
|
Hm. Now that I think about it, we can do 1.2.840.113549.1.1.4 for MD5 support. @bartonjs, do we want an MD5WithRsa OID here? |
| "50EBAAC4460DAA35185C16670F597E0E6E0CB0AA83F51AAEF452F3367DD9350A" + | ||
| "8A49A5A8F79DF8E921303AB5D6646A482F0F59D9980310E1AE3EE8D77CB857").HexToByteArray(); | ||
|
|
||
| internal static readonly byte[] RsaPkcs1signedSha1DeclaredSha256WithRsa = ( |
There was a problem hiding this comment.
the S in signed should be uppercase :)
Eh, I'd leave it out unless there's a reason to bother later. |
Fixes #32639
Makes sense. I have no compelling reason to put it there other than completeness, and I'm not particularly fond of MD5-anything. Fixed the casing issue. |
|
@dotnet-bot Test this please (lots of failures due to what looks like a Jenkins restart) |
|
@vcsjones The (valid) test document you added doesn't have indefinite length content, right? (I don't see an 0x24, so it shouldn't be; but making sure I'm not being redundant) |
|
@bartonjs no they do not, I didn't want to risk cramming two issues into the same CMS. |
This adds additional OIDs for RSA CMS validation when the OID is specific about which hash algorithm should be used.
This is a slightly different approach from the DSA / ECDsa approach. This allows for a null
HashAlgorithmNameand does not enforce the hash algorithm if one is not specified when using the "1.2.840.113549.1.1.1" OID.Fixes #32639