[release/2.1] Servicing SignedCms for Signed NuGet Packages

[bartonjs]

Backports of #32666 (registration for alternate RSA signature identifiers) and #32704 (indefinite-length encoded content) to release/2.1

Description

Windows CMS (and therefore .NET Framework) is more permissive on SignedCms content than the .NET Core implementation of SignedCms.

OIDs: The .NET Foundation has created Signed NuGet packages which validate on .NET Framework, but not .NET Core, as .NET Core does not recognize the signature algorithm identifier.

Encoding: The .NET Foundation has created Signed NuGet packages which cannot be countersigned by .NET Core.

Customer Impact

Customers will be unable to work with RSA-signed packages signed by the .NET Foundation using the X.509 signature algorithm identifier instead of the CMS algorithm identifier.

Packages signed by The .NET Foundation may decode correctly, but cannot be re-encoded.

Regression?

The OID entries are a behavioral regression from .NET Framework, but not a regression within .NET Core.

The indefinite-length encoding content issue was a regression from #30432 (which released in 2.1.5).

Packaging reviewed?

Packaging considered, reviewers tagged.

Risk

Low. Existing unit tests provide assurance that the formats written by .NET Core and .NET Framework still behave as expected, new unit tests guard against regressions from variants encountered from the signing service set up by The .NET Foundation based on Bouncy Castle.

---

Since both of these changes require the package harvesting manifest to be updated, the package index to be updated, the version of System.Security.Cryptography.Pkcs to be bumped, and System.Security.Cryptography.Pkcs to be registered for build/publish, they have been bundled into one change. They could be separated if desired.

[danmoseley]

@wtgodbe can you please verify the packaging changes.

[safern]

Packaging stuff looks good.

[bartonjs]

@dotnet-bot Test Windows x64 Debug Build please (network timeout)
Test OSX x64 Debug Build please (#28360)

[bartonjs]

I seem to have won the lottery.

2018-11-14 07:53:05,281: INFO: proc(55): run_and_log_output: Output: Starting:    System.Collections.Concurrent.Tests
2018-11-14 07:53:11,069: INFO: proc(55): run_and_log_output: Output: Assertion Failed
2018-11-14 07:53:11,069: INFO: proc(55): run_and_log_output: Output: 
2018-11-14 07:53:11,070: INFO: proc(55): run_and_log_output: Output:    at System.Collections.Concurrent.ConcurrentBag`1.WorkStealingQueue.get_DangerousCount() in /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.1/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentBag.cs:line 1055
2018-11-14 07:53:11,071: INFO: proc(55): run_and_log_output: Output:    at System.Collections.Concurrent.ConcurrentBag`1.get_DangerousCount() in /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.1/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentBag.cs:line 521
2018-11-14 07:53:11,071: INFO: proc(55): run_and_log_output: Output:    at System.Collections.Concurrent.ConcurrentBag`1.ToArray() in /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.1/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentBag.cs:line 390
2018-11-14 07:53:11,072: INFO: proc(55): run_and_log_output: Output:    at System.Collections.Concurrent.Tests.ConcurrentBagTests.<>c__DisplayClass18_0.<Clear_ConcurrentUsage_NoExceptions>b__1() in /Users/dotnet-bot/j/workspace/dotnet_corefx/release_2.1/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Collections.Concurrent/tests/ConcurrentBagTests.netcoreapp.cs:line 85
2018-11-14 07:53:11,076: INFO: proc(55): run_and_log_output: Output:    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
2018-11-14 07:53:11,076: INFO: proc(55): run_and_log_output: Output:    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
2018-11-14 07:53:11,076: INFO: proc(55): run_and_log_output: Output:    at System.Threading.ThreadPoolWorkQueue.Dispatch()

https://mc.dot.net/#/user/bartonjs/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Frelease~2F2.1~2F/test~2Ffunctional~2Fcli~2F/a27a04349e8d52a75261351271da8910c63ec177/workItem/System.Collections.Concurrent.Tests/wilogs

@stephentoub is taking a look to see if he can reason about it; but it seems fairly unrelated to this change (and hadn't failed on the previous run)

[vivmishra]

Approved for 2.1.7 and 2.2.1