This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Allow transporting an indefinite-length encoding for content in SignedCms#32704
Merged
bartonjs merged 1 commit intodotnet:masterfrom Oct 9, 2018
Merged
Conversation
…dCms SignedCms reads BER, because the spec says to, and writes DER, to provide better interop. If the incoming message used an indefinite length encoding for SignedData.encapContentInfo.eContent's ANY value the call to Encode will throw (as will any mutation operations which internally use Encode). With this change, if writing DER fails then assemble the output in pieces to leave the encapsulated content as-is while DER-normalizing the rest of the structure.
krwq
approved these changes
Oct 9, 2018
Member
krwq
left a comment
krwq
left a comment
There was a problem hiding this comment.
lgtm, can't see any easy way to add more validation
GrabYourPitchforks
approved these changes
Oct 9, 2018
Member
|
I appreciated the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignedCms reads BER, because the spec says to, and writes DER, to provide
better interop. If the incoming message used an indefinite length encoding
for SignedData.encapContentInfo.eContent's ANY value the call to Encode
will throw (as will any mutation operations which internally use Encode).
With this change, if writing DER fails then assemble the output in pieces to leave
the encapsulated content as-is while DER-normalizing the rest of the structure.
Fixes #32679