Expose 64-bit only hardware intrinsic in nested classes#33286
Conversation
|
@dotnet-bot test this please |
| MembersMustExist : Member 'System.Runtime.Intrinsics.X86.Avx2.BroadcastScalarToVector256(System.Runtime.Intrinsics.Vector128<System.UInt16>)' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'System.Runtime.Intrinsics.X86.Avx2.BroadcastScalarToVector256(System.Runtime.Intrinsics.Vector128<System.UInt32>)' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'System.Runtime.Intrinsics.X86.Avx2.BroadcastScalarToVector256(System.Runtime.Intrinsics.Vector128<System.UInt64>)' does not exist in the implementation but it does exist in the contract. | ||
| warning : Did not find type 'T:System.Runtime.Intrinsics.X86.Bmi1.X64' in any of the seed assemblies. |
There was a problem hiding this comment.
I'm not sure we need this. I had seen it in my PR, initially as well. But it appears to have gone away after rebasing onto the current HEAD.
There was a problem hiding this comment.
According to my experience, we need this for "Packaging All Configurations x64 Debug Build"
There was a problem hiding this comment.
@ericstj, I think we might've discussed this previously.
For some reason, the tooling is not picking the System.Private.Corelib that we are building against, and is instead picking up an older copy.
There was a problem hiding this comment.
Looking at the binlog, the seed assemblies being passed in are:
C:\Users\tagoo\.nuget\packages\microsoft.targetingpack.private.netnative\1.1.0-beta-27106-00\lib\uap10.1\System.Private.CoreLib.dll
E:\Users\tagoo\Repos\corefx\artifacts\bin\ref/netcoreapp/netstandard.dll
There was a problem hiding this comment.
Hmmm, actually; even the updated package still doesn't have the new types
- You can validate that the changes pass locally with
.\build.cmd -allConfigurations
@ericstj, do you know what is required to get it to ignore the Did not find type 'T:System.Runtime.Intrinsics...' in any of the seed assemblies. messages? Just adding the exact text doesn't appear to work.
There was a problem hiding this comment.
Is this a scenario that is only handled by ignoreMissingTypes?
- It would also be good to find out why the uap corelib isn't updated here.... These are part of the shared types and have been checked in on the CoreCLR side for a few days now
There was a problem hiding this comment.
I tried adding Errors were encountered when generating facade(s)., but still does not work...
5 participants
Match the CoreCLR change dotnet/coreclr#20146
@tannergooding @eerhardt