This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Move the various helper intrinsics to be implemented on the S.R.Intrinsics.Vector types#33302
Merged
Conversation
tannergooding
commented
Nov 7, 2018
|
|
||
| namespace System.Runtime.Intrinsics | ||
| { | ||
| public static class Vector64 |
Member
Author
There was a problem hiding this comment.
Likely the only thing worth noting is that for double, long, and ulong, only the Create(T value) overload is given. The CreateScalar and CreateScalarUnsafe would do the same thing, since the Vector64<T> can only hold a single element of these types.
| private readonly int _dummy; | ||
| private readonly int _dummy; | ||
| public static Vector64<T> Zero { get { throw null; } } | ||
| public Vector64<U> As<U>() where U : struct { throw null; } |
Member
There was a problem hiding this comment.
We discussed why this uses : struct instead of : unmanaged - mainly to allow wider use within the ecosystem. Makes sense.
Member
GrabYourPitchforks
left a comment
GrabYourPitchforks
left a comment
There was a problem hiding this comment.
Suggested some renamings, otherwise LGTM.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…nsics.Vector types (dotnet/corefx#33302) * Move the various helper intrinsics to be implemented on the S.R.Intrinsics.Vector types * Expose 64-bit only hardware intrinsic in nested classes * Updating the System.Runtime.Intrinsics ApiCompatBaseline for netcoreappaot Commit migrated from dotnet/corefx@91bad8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the CoreFX side to dotnet/coreclr#20147