This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Moving the Utf8Parser/Utf8Formatter to be shared#33348
Merged
stephentoub merged 1 commit intodotnet:masterfrom Nov 9, 2018
tannergooding:share-utf8-parseformat
Merged
Moving the Utf8Parser/Utf8Formatter to be shared#33348stephentoub merged 1 commit intodotnet:masterfrom tannergooding:share-utf8-parseformat
stephentoub merged 1 commit intodotnet:masterfrom
tannergooding:share-utf8-parseformat
Conversation
Member
Author
|
CC. @stephentoub, @jkotas |
Member
Author
|
Also CC. @GrabYourPitchforks |
jkotas
approved these changes
Nov 9, 2018
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/corert
that referenced
this pull request
Nov 9, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/coreclr
that referenced
this pull request
Nov 9, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Nov 9, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Nov 9, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #20873 (comment), I split the PR into multiple
This is the second PR and moves the UTF8 Parser and Formatter to be shared. This will make tracking the history better and make the PR that moves it into S.P.CoreLib to be smaller.