This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[master] Update dependencies from dotnet/coreclr#35586
Closed
dotnet-maestro[bot] wants to merge 3 commits intomasterfrom
Closed
[master] Update dependencies from dotnet/coreclr#35586dotnet-maestro[bot] wants to merge 3 commits intomasterfrom
dotnet-maestro[bot] wants to merge 3 commits intomasterfrom
Conversation
…0225.73 This change updates the following dependencies - Microsoft.NET.Sdk.IL - 3.0.0-preview4-27425-73 - Microsoft.NETCore.ILAsm - 3.0.0-preview4-27425-73 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview4-27425-73
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
|
build failure |
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
|
@ericstj, this one failed, too, but on all legs and with a different error this time. Is this related to your changes? |
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
|
Yep, this is me. I will fix in CoreCLR ASAP. Looks like a did a bad rebase :(. |
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
|
Thanks. |
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Member
|
Once CoreCLR PR goes in we'll need #35593 to fix a minor issue on consumption. That PR is independent of the CoreCLR change, but if its not merged by the time we have a CoreCLR build ingestion we'll need to cherry-pick it. |
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…0226.72 This change updates the following dependencies - Microsoft.NET.Sdk.IL - 3.0.0-preview4-27426-72 - Microsoft.NETCore.ILAsm - 3.0.0-preview4-27426-72 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview4-27426-72
stephentoub
deleted the
darc-master-41e7e7a1-5a18-4a38-ab08-c41f0e7f43af
branch
Member
|
Hi @stephentoub what are next steps to get CoreCLR updated in CoreFx. Are we just waiting for another auto-PR? Will we be waiting until tomorrow? If so I'll submit a manual update. I want to make sure I get this in as it is blocking some other infra work I am doing. Thanks! |
Member
|
coreclr has breaking changes that need to be fixed first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Updates from https://github.com/dotnet/coreclr
Updates from https://github.com/dotnet/coreclr