This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Use ILAsm/ILDasm that are restored as part of external#35593
Merged
ericstj merged 2 commits intodotnet:masterfrom Feb 26, 2019
Merged
Use ILAsm/ILDasm that are restored as part of external#35593ericstj merged 2 commits intodotnet:masterfrom
ericstj merged 2 commits intodotnet:masterfrom
Conversation
ericstj
requested review from
ViktorHofer,
safern,
stephentoub and
tannergooding
This was referenced Feb 26, 2019
ViktorHofer
reviewed
Feb 26, 2019
ViktorHofer
approved these changes
Feb 26, 2019
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
LGTM besides the one ask.
Also fixes a test project to build correctly and deletes a checked in binary.
ericstj
force-pushed
the
ILAsm-restore
branch
from
d57dbb3 to
7e85e22
Compare
Before this change all tests are forced to use the Open key. Now tests can specify TestStrongNameKeyId to control their key.
ViktorHofer
approved these changes
Feb 26, 2019
safern
approved these changes
Feb 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes a test project to build correctly and deletes a checked in binary.