This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[master] Update dependencies from dotnet/coreclr#36922
Merged
tannergooding merged 6 commits intomasterfrom Apr 17, 2019
Merged
Conversation
…0415.72 - Microsoft.NET.Sdk.IL - 3.0.0-preview5-27615-72 - Microsoft.NETCore.ILAsm - 3.0.0-preview5-27615-72 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27615-72
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
safern
approved these changes
Apr 16, 2019
Member
|
Failing CI tests are perhaps due to dotnet/coreclr#23833? Though I looked over the PR and everything seems good. Still investigating. |
Member
===========================================================================================================
Discovering: System.Reflection.Emit.Lightweight.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Reflection.Emit.Lightweight.Tests (found 1 of 38 test case)
Starting: System.Reflection.Emit.Lightweight.Tests (parallel test collections = on, max threads = 8)
Assert failure(PID 14172 [0x0000375c], Thread: 14524 [0x38bc]): FitsIn<unsigned short>(EHSize)
CORECLR! LCGMethodResolver::GetCodeInfo + 0x479 (0x00007ffe`381f1499)
CORECLR! getMethodInfoHelper + 0x195B (0x00007ffe`380066ff)
CORECLR! UnsafeJitFunction + 0x330 (0x00007ffe`37fe02f8)
CORECLR! MethodDesc::JitCompileCodeLocked + 0x1B4 (0x00007ffe`38067d70)
CORECLR! MethodDesc::JitCompileCodeLockedEventWrapper + 0x303 (0x00007ffe`380682ab)
CORECLR! MethodDesc::JitCompileCode + 0x4CF (0x00007ffe`38067adb)
CORECLR! MethodDesc::PrepareILBasedCode + 0x18E (0x00007ffe`380699ea)
CORECLR! MethodDesc::PrepareCode + 0xFF (0x00007ffe`3806961b)
CORECLR! MethodDesc::PrepareInitialCode + 0xEF (0x00007ffe`38069b3f)
CORECLR! MethodDesc::DoPrestub + 0x837 (0x00007ffe`38062c8f)
File: C:\coreclr\src\vm\dynamicmethod.cpp Line: 1118
Image: C:\corefx\artifacts\bin\testhost\netcoreapp-Windows_NT-Debug-x64\dotnet.exe |
Member
|
The coreclr fix which unblocks this PR will be in the 3.0.0-preview5-27616-73 train. |
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
…0416.72 - Microsoft.NET.Sdk.IL - 3.0.0-preview5-27616-72 - Microsoft.NETCore.ILAsm - 3.0.0-preview5-27616-72 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27616-72
Member
|
@GrabYourPitchforks let me know if you need help doing a manual update or something to get the fix for this PR. |
…System.MathF to expect NaN propagation
Member
|
Spoke with @tannergooding offline. We're cherry-picking #36935 into this PR to unblock the merge. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Update dependencies from https://github.com/dotnet/coreclr build 20190415.72 - Microsoft.NET.Sdk.IL - 3.0.0-preview5-27615-72 - Microsoft.NETCore.ILAsm - 3.0.0-preview5-27615-72 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27615-72 * Update dependencies from https://github.com/dotnet/coreclr build 20190416.72 - Microsoft.NET.Sdk.IL - 3.0.0-preview5-27616-72 - Microsoft.NETCore.ILAsm - 3.0.0-preview5-27616-72 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27616-72 * Update CoreCLR dependencies to 3.0.0-preview5-27616-73 * Fixing the Min/Max and MinMagnitude/MaxMagnitude for System.Math and System.MathF to expect NaN propagation Commit migrated from dotnet/corefx@818355a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/coreclr
From https://github.com/dotnet/coreclr