Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Manually updating dependencies in order to get the new coreclr packages.#36976

Merged
tarekgh merged 4 commits intodotnet:masterfrom
joperezr:UpdateCoreclr
Apr 18, 2019
Merged

Manually updating dependencies in order to get the new coreclr packages.#36976
tarekgh merged 4 commits intodotnet:masterfrom
joperezr:UpdateCoreclr

Conversation

@joperezr
Copy link
Copy Markdown
Member

@joperezr joperezr commented Apr 17, 2019

FYI: @tarekgh @tannergooding since you both wanted a new version of coreclr ingested into corefx

This PR is manually updating our dependencies in order to bring some required changes from coreclr in. This PR is also doing the changes from #36927 per @tarekgh's request, which was doing an update the Index and Range interfaces and tests

@tannergooding
Copy link
Copy Markdown
Member

#36922 is also actively still going and looks to have all the stuff I need

@tarekgh
Copy link
Copy Markdown
Member

tarekgh commented Apr 17, 2019

@tannergooding do you need to update anythining corefx side for your changes?

@tannergooding
Copy link
Copy Markdown
Member

do you need to update anythining corefx side for your changes?

Yes, but those are included in the nearly complete PR I just linked.

@tannergooding
Copy link
Copy Markdown
Member

(as well as are other fixes that are required)

@tarekgh
Copy link
Copy Markdown
Member

tarekgh commented Apr 17, 2019

I think it will make more sense if we cherry pick the commits we have here to #36922 . or we have to wait for #36922 to finish first and then restart this one.

@tannergooding
Copy link
Copy Markdown
Member

@joperezr, @tarekgh. This should be unblocked now.

@tarekgh tarekgh closed this Apr 17, 2019
@tarekgh tarekgh reopened this Apr 17, 2019
@tarekgh tarekgh merged commit d5a5f3c into dotnet:master Apr 18, 2019
@tarekgh
Copy link
Copy Markdown
Member

tarekgh commented Apr 18, 2019

thanks @joperezr for the help here.

@joperezr joperezr deleted the UpdateCoreclr branch April 18, 2019 16:05
@karelz karelz added this to the 3.0 milestone May 4, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…es. (dotnet/corefx#36976)

* Update the Index and Range interfaces and tests

* Fix api compat failure with utf8string

* Fix the test to use Assert.Throws

* Update dependencies manually


Commit migrated from dotnet/corefx@d5a5f3c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants