This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix Loop in System.Private.Uri#38076
Merged
wtgodbe merged 3 commits intodotnet:masterfrom May 31, 2019
Merged
Conversation
Contributor
|
I assume this is the same as #37733? |
Member
Author
|
@davidsh yes, that PR wasn't updating when I pushed a new commit (for some reason), so I just closed it & reopened this PR against the same branch. |
Contributor
|
Please run all Outerloop tests as well. |
Member
Author
|
/apz run corefx-outerloop-windows |
Member
Author
|
/azp run corefx-outerloop |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run corefx-outerloop |
|
No pipelines are associated with this pull request. |
davidsh
approved these changes
May 30, 2019
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
|
@wtgodbe You can't put all 3 azp commands in one comment, #38076 (comment) You need to do each one at a time. Or do "/azp run" which runs all inner and outerloop |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 3 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s), but failed to run 1 pipeline(s). |
stephentoub
approved these changes
May 31, 2019
Member
Author
|
Outerloop failures are unrelated, merging |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix Loop in System.Private.Uri * Mark variables in test project as private * Disable test on NetFx Commit migrated from dotnet/corefx@0f2fa63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports 6da61ff to master
CC @karelz @davidsh