This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.1] Disable tests on netfx for loop in URI & IPv6AddressHelper#38224
Merged
wtgodbe merged 1 commit intodotnet:release/2.1from Jun 5, 2019
Merged
[release/2.1] Disable tests on netfx for loop in URI & IPv6AddressHelper#38224wtgodbe merged 1 commit intodotnet:release/2.1from
wtgodbe merged 1 commit intodotnet:release/2.1from
Conversation
davidsh
changed the title
stephentoub
approved these changes
Jun 4, 2019
davidsh
approved these changes
Jun 4, 2019
bartonjs
approved these changes
Jun 5, 2019
tommcdon
pushed a commit
that referenced
this pull request
Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @davidsh @karelz @danmosemsft
Description
Back-ports test fixes from #37734 and #38076 to 2.1. Some of these test cases should be disabled on netfx until our test machines have the latest patches, otherwise they will fail.
Customer Impact
Customers running our test suite on desktop won't see unexpected/surprising test failures
Regression?
Just a test fix, so should not cause any
Risk
We may forget to circle back and re-enable these on netfx once an appropriate amount of time has passed.