This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Await for responseHeadersTask to observe exception if any#38358
Closed
wfurt wants to merge 1 commit intodotnet:masterfrom
Closed
Await for responseHeadersTask to observe exception if any#38358wfurt wants to merge 1 commit intodotnet:masterfrom
wfurt wants to merge 1 commit intodotnet:masterfrom
Conversation
davidsh
changed the title
JamesNK
reviewed
Jun 8, 2019
| } | ||
| else | ||
| { | ||
| await responseHeadersTask; |
Member
There was a problem hiding this comment.
Comment explaining why (like what you said in the issue)
😄
stephentoub
reviewed
Jun 8, 2019
| else | ||
| { | ||
| await responseHeadersTask; | ||
|
|
Member
There was a problem hiding this comment.
Shouldn't the await be moved down to below the ContinueWith and nulling out below?
Member
Author
|
I'll make this part of #38226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is race condition when we get RST from server. In this case the RST git during processing body but because we did not finish handing out HttpResponseMessage we faulted the receiving task. Since we fail to throw, we were hitting NRE in some unrelated code while trying to dereference response we never processed.
Since this depends on race in task processing I did not add new test.
fixes #38293